Map post-approval deadline checks through typed login errors

Signed-off-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a0c095-4917-7617-9dac-e99f1ef22d41
Co-authored-by: Isaac Miller <isaac@cmpnd.ai>

Author: ampagent

lm15/login/manager.py

@@ -361,6 +361,7 @@ def login(
             flow = _flow(provider, chosen.id)
             try:
                 result = flow.login(ctx, chosen, settings, answers)
+                ctx.check()
             except LoginCancelled:
                 self._release(provider, attempt_id)
                 raise
@@ -391,7 +392,6 @@ def login(
             except LM15Error:
                 self._release(provider, attempt_id)
                 raise
-            ctx.check()
             return self._commit(provider, attempt_id, expected, chosen, result, settings)
         except BaseException:
             # Any exit without a saved connection ends the attempt — Ctrl-C

tests/test_login.py

@@ -500,6 +500,25 @@ async def run():
     assert reopened.store.read()["xai"]["key"] == "newer"
 
 
+def test_login_expiring_after_approval_returns_typed_error(sandbox: Path, monkeypatch) -> None:
+    from lm15.login.flows.base import LoginResult
+    from lm15.login.flows.xai import XaiFlow
+
+    clock = Clock()
+    auth = make_auth(sandbox, clock)
+
+    def expired_approval(self, ctx, method, settings, answers):
+        clock.advance(61)
+        return LoginResult(material={"type": "api_key", "key": "late"}, label="late")
+
+    monkeypatch.setattr(XaiFlow, "login", expired_approval)
+    with pytest.raises(AuthOperationError) as error:
+        auth.login("xai", "device", ui=ScriptUI(), lifetime_s=60)
+    assert error.value.reason == "login_expired"
+    assert auth.status("xai").presence == "absent"
+    assert auth.set_api_key("xai", "later").provider == "xai"
+
+
 def test_an_interrupt_ends_the_attempt_and_frees_the_slot(sandbox: Path) -> None:
     # Ctrl-C — a notebook's cancel — while waiting for the provider, or at
     # a prompt: the attempt is over, so its reservation must not block the