Skip to content

Commit d27dfae

Browse files
ampagentIsaac Miller
andcommitted
Record reproduced auth review fixes in downstream stack
Signed-off-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a0c095-4917-7617-9dac-e99f1ef22d41 Co-authored-by: Isaac Miller <isaac@cmpnd.ai>
1 parent a838f91 commit d27dfae

1 file changed

Lines changed: 31 additions & 2 deletions

File tree

‎DOWNSTREAM_PATCHES.md‎

Lines changed: 31 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,16 +32,45 @@ unpatched and do not rewrite published integration branches.
3232
preparing an operation. Sync/async regressions verify the documented
3333
transport replacement escape hatch sends only through the caller's
3434
replacement transport.
35+
5. `8671868feb55408c2a11bbea2413f9a7d70ebe9b`: expose the descriptor
36+
collection as `lm15.login_providers` (also `lm15.login.providers`).
37+
The attempted lazy `providers` export was hidden by the existing provider
38+
implementation package. Keep that package and its submodules intact.
39+
Fresh-interpreter import-order regressions live in tests/test_login_exports.py.
40+
6. `cd7ef071d0399af28b0e88a71bfd11f97a859cb8`: wait for dismissed terminal
41+
manual input to relinquish stdin before returning to a subsequent picker.
42+
The existing "press Enter to continue" interaction remains; no portable
43+
cancellation of blocking input is assumed. Tests/test_terminal_login.py
44+
covers a real loopback callback with controlled input, early dismissal,
45+
completed reads and interrupted reads.
46+
7. `a838f91648c844416d75697273c38646caddec8f`: resolve sibling routes to
47+
their advertised saved connection for requests, renewal, status and
48+
logout; explicit route slots (including logout markers) take precedence.
49+
Async task cancellation signals and durably releases only its own login
50+
attempt before returning CancelledError. A commit already won is not
51+
undone. Verification pins the checked connection and records results
52+
only if its identity/generation still matches. Tests/test_login.py covers
53+
all three Meta routes with remint/endpoint change/logout, cooperative and
54+
non-cooperative cancelled login workers, and valid/rejected verification
55+
with and without concurrent replacement.
3556

36-
All four patches remain necessary in v1.3.0. Its Meta login changes supply
57+
The first four patches remain necessary in v1.3.0. Its Meta login changes supply
3758
the minted endpoint and plan; they do not change bound selection, renewal
3859
HTTP 429 handling or managed dispatch. The replay has no patch-content
3960
changes from the validated v1.2.3 stack. Meta login remains unverified and
4061
requires explicit opt-in because of the documented terms and data-use risks.
4162

63+
Patches 5–7 address five reproduced findings from DSPy #10540's October 13
64+
Greptile review. The focused before/after run failed 14 cases on the previous
65+
tip (with 3 controls passing); all pass after the fixes. These new patches
66+
are downstream only and are published on the integration and contribution
67+
branches below, not claimed submitted or merged upstream.
68+
4269
The first two fixes originate on cmpnd-ai/lm15-python branch
4370
fix/managed-auth-review. The routing fixes are published on
44-
fix/managed-request-snapshots. Upstream PR submission was denied by GitHub
71+
fix/managed-request-snapshots, with the 1.3.0 stack and review fixes on
72+
fix/managed-request-snapshots-1.3.0 and integration/lm15-1.3.0-patches.
73+
Upstream PR submission was denied by GitHub
4574
integration permissions; no patch is claimed to be merged upstream. Check
4675
for an existing upstream PR before attempting submission again.
4776

0 commit comments

Comments
 (0)