sql: validate recursive CTE references in subqueries and outer joins - #174792
Open
shashi1973 wants to merge 1 commit into
Open
sql: validate recursive CTE references in subqueries and outer joins#174792shashi1973 wants to merge 1 commit into
shashi1973 wants to merge 1 commit into
Conversation
Fixes: cockroachdb#136623 Release note (bug fix): Recursive CTE references in subqueries and on the null-extended side of outer joins are now rejected to match PostgreSQL behavior.
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #136623
This change adds PostgreSQL-compatible validation for recursive CTE
references in contexts where PostgreSQL does not allow them.
Specifically, it rejects recursive references that occur:
The validation tracks the subquery and outer-join context relative to
the start of the recursive term. This avoids rejecting a recursive CTE
merely because the CTE itself appears inside an enclosing subquery.
Tests cover:
subquery remains valid when the recursive reference itself is not
inside another subquery
Testing:
./dev test pkg/sql/opt/optbuilder --filter=TestBuilder./dev generate./dev lint --shortwas also run. The lint run was blocked by theexisting CODEOWNERS check reporting stale paths
**.pb.goand**.pb.gw.go; no lint failure was reported for the files changed bythis PR.
Release note (bug fix): Recursive CTE references in subqueries and on
the null-extended side of outer joins are now rejected to match
PostgreSQL behavior.