Skip to content

Revert "Fix applyTargetOverrides checks if property is declared to event residual data (#18856) - #19072

Merged
star-e merged 1 commit into
cocos:v3.8.8from
knoxHuang:fix-bbb
Nov 17, 2025
Merged

Revert "Fix applyTargetOverrides checks if property is declared to event residual data (#18856)#19072
star-e merged 1 commit into
cocos:v3.8.8from
knoxHuang:fix-bbb

Conversation

@knoxHuang

@knoxHuang knoxHuang commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

This reverts commit 986bdc1.

Re: #

https://forum.cocos.org/t/topic/171783/4

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@knoxHuang
knoxHuang requested a review from star-e November 17, 2025 09:18
@knoxHuang

Copy link
Copy Markdown
Contributor Author

@cocos-robot run test cases

@star-e

star-e commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

@cocos-robot run test cases

@github-actions

Copy link
Copy Markdown

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1009831 bytes 1009738 bytes 👍 -93 bytes
2D All (legacy pipeline) 2675390 bytes 2675297 bytes 👍 -93 bytes
2D All (new pipeline) 2767126 bytes 2767033 bytes 👍 -93 bytes
(2D + 3D) All 10024124 bytes 10024031 bytes 👍 -93 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16843186 bytes 16843093 bytes 👍 -93 bytes

Interface Check Report

This pull request does not change any public interfaces !

@github-actions

Copy link
Copy Markdown

@knoxHuang, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL
ios PASS PASS FAIL
mac PASS PASS PASS

@github-actions

Copy link
Copy Markdown

@knoxHuang, Please check the result of run test cases:

Task Details

@star-e
star-e merged commit 78bebb1 into cocos:v3.8.8 Nov 17, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants