Skip to content

add error log #19147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
driftboat wants to merge 2 commits into
base: v3.8.8
Choose a base branch
from
Open

add error log #19147

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4596454
add error log
Mar 3, 2026
8c71e73
Reference: 4.2 Spine 3.8 – Return immediately if the default skin fai…
Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions native/cocos/editor-support/spine/3.8/spine/SkeletonBinary.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,12 @@ SkeletonData *SkeletonBinary::readSkeletonData(const unsigned char *binary, cons
skeletonData->_defaultSkin = defaultSkin;
skeletonData->_skins.add(defaultSkin);
}

if (!this->getError().isEmpty()) {
delete input;
delete skeletonData;
return NULL;
}
Comment on lines +283 to +287

@greptile-apps greptile-apps Bot Mar 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed indentation (tabs vs. spaces)

The inner lines of this new block use hard tabs (\t) for indentation, while the rest of the file uses spaces. This is inconsistent with the surrounding code pattern (e.g., lines 278–281, 294–298) and will appear misaligned in editors configured for space-based indentation.

Suggested change
if (!this->getError().isEmpty()) {
delete input;
delete skeletonData;
return NULL;
}
if (!getError().isEmpty()) {
delete input;
delete skeletonData;
return NULL;
}

Note: The suggestion also removes the unnecessary this-> qualifier on getError(), which aligns with the simpler style in similar code elsewhere in the function.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!


/* Skins. */
for (size_t i = 0, n = (size_t)readVarint(input, true); i < n; ++i) {
Expand Down Expand Up @@ -511,6 +517,7 @@ Attachment *SkeletonBinary::readAttachment(DataInput *input, Skin *skin, int slo

RegionAttachment *region = _attachmentLoader->newRegionAttachment(*skin, String(name), String(path));
if (region == NULL) {
setError("Error reading attachment: ", name.buffer());
return NULL;
}
region->_path = path;
Expand Down
Loading