fix: 缓存的 BlitDesc._blit 更新 - #19161
Open
Magnetismmy wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Code Size Check Report
Interface Check ReportThis pull request does not change any public interfaces ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #
Changelog
缓存的 [BlitDesc._blit]与对象池复用机制不兼容,导致在 shadingScale 改变 blit 分配顺序后读取到失效/被复写的 blit 对象。
复现思路 :多 pass 混合
场景里同时存在:
fullscreen 后处理 blit
UI 渲染
shadingScale 引入的缩放 pass
多帧运行后,用多个不同后处理配置的相机,从A开启切换到B开启,某帧中对象池 slot 被复用
旧 [BlitDesc._blit]指向了被重置后的 UI blit,触发空材质访问
Continuous Integration
This pull request:
Compatibility Check
This pull request: