Skip to content

fix(rendering): add planar shadow rendering support for new render pipeline #19187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
UC-RX0 wants to merge 1 commit into
base: v3.8.8
Choose a base branch
from
+4 −4
Open

fix(rendering): add planar shadow rendering support for new render pipeline #19187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cocos/rendering/custom/scene-culling.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ export class SceneCulling {
enableLightCulling = true;

readonly kFilterMask = SceneFlags.SHADOW_CASTER | SceneFlags.REFLECTION_PROBE;
readonly kDrawMask = SceneFlags.OPAQUE | SceneFlags.MASK | SceneFlags.BLEND;
readonly kDrawMask = SceneFlags.OPAQUE | SceneFlags.MASK | SceneFlags.BLEND | SceneFlags.PLANAR_SHADOW;
readonly kAllMask = this.kFilterMask | this.kDrawMask;

resetPool (): void {
Expand Down
6 changes: 3 additions & 3 deletions cocos/rendering/post-process/passes/forward-pass.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,12 @@ export class ForwardPass extends BasePass {
passContext.addSceneLights(forwardAddQueue, camera);
const shadowInfo = ppl.pipelineSceneData.shadows;
if (camera.scene?.mainLight && shadowInfo.enabled && shadowInfo.type === ShadowType.Planar) {
pass.addQueue(QueueHint.RENDER_TRANSPARENT, 'planar-shadow')
pass.addQueue(QueueHint.RENDER_OPAQUE, 'planar-shadow')
.addSceneOfCamera(
camera,
new LightInfo(camera.scene?.mainLight),
SceneFlags.TRANSPARENT_OBJECT | SceneFlags.SHADOW_CASTER
| SceneFlags.GEOMETRY,
SceneFlags.SHADOW_CASTER | SceneFlags.PLANAR_SHADOW
| SceneFlags.OPAQUE_OBJECT | SceneFlags.CUTOUT_OBJECT,
);
}
passContext.forwardPass = this;
Expand Down
Loading