fix(pipeline): create render graph vertices invalid so culling runs in release builds - #19196
Closed
hakastein wants to merge 1 commit into
Closed
fix(pipeline): create render graph vertices invalid so culling runs in release builds#19196hakastein wants to merge 1 commit into
hakastein wants to merge 1 commit into
Conversation
…n release builds WebPipeline passed `!DEBUG` as the `valid` argument of RenderGraph.addVertex. With CC_DEBUG false every vertex was created valid, so Compiler._fetchValidPass returned at its `if (validPass)` guard for all of them and nothing was culled — the whole render graph was compiled and submitted every frame.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Code Size Check Report
Interface Check ReportThis pull request does not change any public interfaces ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #19194
Changelog
falserather than!DEBUGas thevalidargument ofRenderGraph.addVertexinWebPipeline. WithCC_DEBUGfalse every render graph vertex was created valid, soCompiler._fetchValidPassreturned at itsif (validPass)guard for all of them and nothing was culled — the whole graph was compiled and submitted every frame.Continuous Integration
This pull request:
Compatibility Check
This pull request: