fix(SRP): crash when native OpenAL is unavailable by troublemaker52025 · Pull Request #195 · cocos/cocos4

troublemaker52025 · 2026-07-10T03:59:58Z

Re: #

Changelog

原生 Audio 存在一个设计缺陷：当 OpenAL 不可用时，会使用这个 sAudioEngineImpl = nullptr 指针直接调用 getPCMHeader()、getOriginalPCMBuffer() 导致程序崩溃
现在按照以下三种情况修复：

情况	处理
OpenAL 可用且已初始化	直接复用 `sAudioEngineImpl` ，无额外开销
OpenAL 可用但尚未初始化	`lazyInit()` 触发完整初始化，行为与改动前完全一致
OpenAL 不可用	`lazyInit()` 失败后降级到 `sDecoderImpl` ，PCM 解码依然正常

Continuous Integration

This pull request:

needs automatic test cases check.

Manual trigger with @cocos-robot run test cases afterward.
does not change any runtime related code or build configuration

If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.

Compatibility Check

This pull request:

changes public API, and have ensured backward compatibility with deprecated features.
affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
affects file structure of the build package or build configuration which requires user project upgrade.
introduces breaking changes, please list all changes, affected features and the scope of violation.

troublemaker52025 · 2026-07-10T04:01:18Z

@cocos-robot run test cases

github-actions · 2026-07-10T04:36:47Z

Code Size Check Report

Wechat (WASM)	Before	After	Diff
2D Empty (legacy pipeline)	1014446 bytes	1014446 bytes	✅ 0 bytes
2D All (legacy pipeline)	2681971 bytes	2681971 bytes	✅ 0 bytes
2D All (new pipeline)	2773763 bytes	2773763 bytes	✅ 0 bytes
(2D + 3D) All	10031072 bytes	10031072 bytes	✅ 0 bytes

Web (WASM + ASMJS)	Before	After	Diff
(2D + 3D) All	16867485 bytes	16867485 bytes	✅ 0 bytes

Interface Check Report

This pull request does not change any public interfaces !

github-actions · 2026-07-10T06:03:32Z

@troublemaker52025, Please check the result of run test cases:

Test Platform: PR-Test
Editor Version: v4.0.0
Task Result: FAIL
Task URL: https://cctest.cocos.org/#/reportview/PR-TEST/b2f8e823-0f88-4515-a8df-e3d0cce65210/-1
GitHub Action: https://github.com/cocos/cocos4/actions/runs/29068085225

Task Details

Platform	build	boot	runned	FailScene
web-mobile	PASS	PASS	FAIL	graphics-draw-before-init
ios	PASS	PASS	PASS
mac	PASS	PASS	PASS

github-actions · 2026-07-10T06:03:33Z

@troublemaker52025, Please check the result of run test cases:

Test Platform: PR-Test
Editor Version: v4.0.0
Task Result: PASS
Task URL: https://cctest.cocos.org/#/reportview/PR-TEST/7e540089-88cf-4a2c-875e-cd266571d13b/-1
GitHub Action: https://github.com/cocos/cocos4/actions/runs/29068085225

Task Details

Copilot

Pull request overview

Fixes a crash in the native AudioEngine PCM decode APIs (getPCMHeader / getOriginalPCMBuffer) when the OpenAL-backed AudioEngineImpl cannot be initialized, by introducing a decoder-only fallback path.

Changes:

Adds a decoder-only initialization entrypoint (AudioEngineImpl::initDecoder) and routes PCM decode APIs through a dedicated getDecoderImpl() selector.
Improves OpenAL initialization error handling/logging when device/context creation fails.
Applies multiple formatting/comment cleanups across platform backends (oalsoft/apple/android).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
native/cocos/audio/oalsoft/AudioEngine-soft.h	Adds `initDecoder()` declaration; minor comment formatting.
native/cocos/audio/oalsoft/AudioEngine-soft.cpp	Implements `initDecoder()`, adds OpenAL init error checks/logs, and minor comment formatting.
native/cocos/audio/include/AudioEngine.h	Adds protected `getDecoderImpl()` strategy + decoder-only fallback member.
native/cocos/audio/AudioEngine.cpp	Implements `sDecoderImpl`, `getDecoderImpl()`, and routes PCM APIs through it.
native/cocos/audio/apple/AudioEngine-inl.mm	Adds `AudioEngineImpl::initDecoder()` stub for uniform compilation.
native/cocos/audio/apple/AudioEngine-inl.h	Declares `initDecoder()`; minor comment formatting.
native/cocos/audio/android/AudioEngine-inl.h	Declares `initDecoder()`; minor formatting.
native/cocos/audio/android/AudioEngine-inl.cpp	Adds `initDecoder()` stub; mostly formatting/indentation changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

troublemaker52025 · 2026-07-10T07:10:32Z

@cocos-robot run test cases

github-actions · 2026-07-10T10:29:09Z

@troublemaker52025, Please check the result of run test cases:

Test Platform: PR-Test
Editor Version: v4.0.0
Task Result: PASS
Task URL: https://cctest.cocos.org/#/reportview/PR-TEST/2d87bf63-33bd-4180-92fa-1796f1577d2b/-1
GitHub Action: https://github.com/cocos/cocos4/actions/runs/29075888289

Task Details

github-actions · 2026-07-10T10:29:09Z

@troublemaker52025, Please check the result of run test cases:

Test Platform: PR-Test
Editor Version: v4.0.0
Task Result: PASS
Task URL: https://cctest.cocos.org/#/reportview/PR-TEST/7ab9c339-d8f2-49ba-a653-e2eb618b3afc/-1
GitHub Action: https://github.com/cocos/cocos4/actions/runs/29075888289

Task Details

github-actions · 2026-07-10T13:05:18Z

@troublemaker52025, Please check the result of run test cases:

Test Platform: PR-Test
Editor Version: v4.0.0
Task Result: FAIL
Task URL: https://cctest.cocos.org/#/reportview/PR-TEST/83d528d6-b5eb-4464-919a-b2ac19441a4a/-1
GitHub Action: https://github.com/cocos/cocos4/actions/runs/29082063302

Task Details

Platform	build	boot	runned	FailScene
web-mobile	PASS	PASS	FAIL	graphics-continuous-filling
ios	PASS	PASS	PASS
mac	PASS	PASS	PASS

github-actions · 2026-07-10T13:05:18Z

@troublemaker52025, Please check the result of run test cases:

Test Platform: PR-Test
Editor Version: v4.0.0
Task Result: PASS
Task URL: https://cctest.cocos.org/#/reportview/PR-TEST/4f9fd00e-3f02-4b2e-aaf3-d97088ebe63f/-1
GitHub Action: https://github.com/cocos/cocos4/actions/runs/29082063302

Task Details

qiuguohua · 2026-07-15T03:18:55Z

+    CC_PLATFORM == CC_PLATFORM_LINUX || CC_PLATFORM == CC_PLATFORM_QNX
+    if (AudioEngine::sDecoderImpl == nullptr) {
+        AudioEngine::sDecoderImpl = ccnew AudioEngineImpl();
+        AudioEngineImpl::initDecoder();


Would it be better to make initDecoder() a non-static member function?

I think keep static member function will be batter. Called independently without relying on a full OpenAL initialization

Co-authored-by: qiuguohua <qiuguohua111@126.com>

github-actions · 2026-07-15T07:22:34Z

@troublemaker52025, Please check the result of run test cases:

Test Platform: PR-Test
Editor Version: v4.0.0
Task Result: PASS
Task URL: https://cctest.cocos.org/#/reportview/PR-TEST/ffb8d8ff-9b08-448b-91f0-80615991c9d2/-1
GitHub Action: https://github.com/cocos/cocos4/actions/runs/29387290378

Task Details

github-actions · 2026-07-15T07:22:34Z

@troublemaker52025, Please check the result of run test cases:

Test Platform: PR-Test
Editor Version: v4.0.0
Task Result: PASS
Task URL: https://cctest.cocos.org/#/reportview/PR-TEST/33c38ae3-b56d-4bcc-bdac-fff809a4ea0a/-1
GitHub Action: https://github.com/cocos/cocos4/actions/runs/29387290378

Task Details

github-actions · 2026-07-15T08:50:08Z

@troublemaker52025 ❗ There was an error during the execution of the tasks. Please check the logs for more details.

fix(SRP): crash when native OpenAL is unavailable

21cef2b

troublemaker52025 added 2 commits July 10, 2026 12:10

Add support for multiple platforms

bb5488e

fix android clang-tidy

74de52b

troublemaker52025 requested review from Copilot, qiuguohua and star-e July 10, 2026 06:50

Copilot started reviewing on behalf of troublemaker52025 July 10, 2026 06:51 View session

Copilot AI reviewed Jul 10, 2026

View reviewed changes

Comment thread native/cocos/audio/AudioEngine.cpp

Comment thread native/cocos/audio/oalsoft/AudioEngine-soft.cpp

Comment thread native/cocos/audio/oalsoft/AudioEngine-soft.cpp Outdated

Comment thread native/cocos/audio/oalsoft/AudioEngine-soft.cpp Outdated

troublemaker52025 and others added 2 commits July 10, 2026 15:03

Potential fix for pull request finding

864330e

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

fix copilot high Comment.

6eb4a14

troublemaker52025 added 4 commits July 10, 2026 17:02

revert error that clang-tidy

05029c9

update

5bd54e1

update 2

c3ef7a6

update 3

d8593c5

qiuguohua reviewed Jul 15, 2026

View reviewed changes

troublemaker52025 and others added 2 commits July 15, 2026 11:29

Update native/cocos/audio/oalsoft/AudioEngine-soft.cpp

d9119a3

Co-authored-by: qiuguohua <qiuguohua111@126.com>

fix ci error

a2d2162

qiuguohua approved these changes Jul 15, 2026

View reviewed changes

star-e approved these changes Jul 15, 2026

View reviewed changes

star-e merged commit df96ee8 into cocos:v4.0.0 Jul 15, 2026
35 checks passed

Uh oh!

Conversation

troublemaker52025 commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Continuous Integration

Compatibility Check

Uh oh!

troublemaker52025 commented Jul 10, 2026

Uh oh!

github-actions Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Size Check Report

Interface Check Report

Uh oh!

github-actions Bot commented Jul 10, 2026

Task Details

Uh oh!

github-actions Bot commented Jul 10, 2026

Task Details

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

troublemaker52025 commented Jul 10, 2026

Uh oh!

github-actions Bot commented Jul 10, 2026

Task Details

Uh oh!

github-actions Bot commented Jul 10, 2026

Task Details

Uh oh!

github-actions Bot commented Jul 10, 2026

Task Details

Uh oh!

github-actions Bot commented Jul 10, 2026

Task Details

Uh oh!

qiuguohua Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

troublemaker52025 Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

qiuguohua Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 15, 2026

Task Details

Uh oh!

github-actions Bot commented Jul 15, 2026

Task Details

Uh oh!

Uh oh!

github-actions Bot commented Jul 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

troublemaker52025 commented Jul 10, 2026 •

edited

Loading

github-actions Bot commented Jul 10, 2026 •

edited

Loading