Skip to content

fix(legacy): custom attribute that set format error - #207

Merged
star-e merged 2 commits into
cocos:v4.0.0from
troublemaker52025:fix(legacy)-custom-arrtibute-set-format-error
Jul 20, 2026
Merged

fix(legacy): custom attribute that set format error#207
star-e merged 2 commits into
cocos:v4.0.0from
troublemaker52025:fix(legacy)-custom-arrtibute-set-format-error

Conversation

@troublemaker52025

@troublemaker52025 troublemaker52025 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Re: #

Changelog

与之前 bug 的本质区别:

标准属性模块(position/normal/uv...) 旧版(customAttributes 块)
进入前attr重置 √ attr = nullptr × 无重置,沿用上一块的值
attr赋值来源 当前属性从(geometry.attributes 或 defAttrs[N]) 错误地仍指向上一个标准属性
info是否正确 ×

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@troublemaker52025

Copy link
Copy Markdown
Contributor Author

@cocos-robot run test cases

@github-actions

Copy link
Copy Markdown

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1014446 bytes 1014446 bytes ✅ 0 bytes
2D All (legacy pipeline) 2681971 bytes 2681971 bytes ✅ 0 bytes
2D All (new pipeline) 2773763 bytes 2773763 bytes ✅ 0 bytes
(2D + 3D) All 10031072 bytes 10031072 bytes ✅ 0 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16867485 bytes 16867485 bytes ✅ 0 bytes

Interface Check Report

This pull request does not change any public interfaces !

@github-actions

Copy link
Copy Markdown

@troublemaker52025, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL graphics-draw-before-init
ios PASS PASS PASS
mac PASS PASS PASS

@github-actions

Copy link
Copy Markdown

@troublemaker52025, Please check the result of run test cases:

Task Details

@github-actions

Copy link
Copy Markdown

@troublemaker52025, Please check the result of run test cases:

Task Details

@github-actions

Copy link
Copy Markdown

@troublemaker52025, Please check the result of run test cases:

Task Details

@star-e
star-e merged commit dd1b155 into cocos:v4.0.0 Jul 20, 2026
35 checks passed
@github-actions

Copy link
Copy Markdown

@troublemaker52025 ❗ There was an error during the execution of the tasks. Please check the logs for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants