Skip to content

Fix(legacy): only DEFAULT layer has lighting - #227

Merged
star-e merged 2 commits into
cocos:v4.0.0from
troublemaker52025:fix(legacy)-Only-DEFAULT-layer-has-lighting
Jul 31, 2026
Merged

Fix(legacy): only DEFAULT layer has lighting#227
star-e merged 2 commits into
cocos:v4.0.0from
troublemaker52025:fix(legacy)-Only-DEFAULT-layer-has-lighting

Conversation

@troublemaker52025

@troublemaker52025 troublemaker52025 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@troublemaker52025
troublemaker52025 requested a review from star-e July 24, 2026 10:11
@troublemaker52025

Copy link
Copy Markdown
Contributor Author

@cocos-robot run test cases

@troublemaker52025 troublemaker52025 changed the title Fix(legacy) only default layer has lighting Fix(legacy) only DEFAULT layer has lighting Jul 24, 2026
@troublemaker52025 troublemaker52025 changed the title Fix(legacy) only DEFAULT layer has lighting Fix(legacy): only DEFAULT layer has lighting Jul 24, 2026
@github-actions

Copy link
Copy Markdown

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1014547 bytes 1014490 bytes 👍 -57 bytes
2D All (legacy pipeline) 2682072 bytes 2682015 bytes 👍 -57 bytes
2D All (new pipeline) 2773854 bytes 2773854 bytes ✅ 0 bytes
(2D + 3D) All 10031227 bytes 10031170 bytes 👍 -57 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16867640 bytes 16867583 bytes 👍 -57 bytes

Interface Check Report

This pull request does not change any public interfaces !

@github-actions

Copy link
Copy Markdown

@troublemaker52025, Please check the result of run test cases:

Task Details

@github-actions

Copy link
Copy Markdown

@troublemaker52025, Please check the result of run test cases:

Task Details

@star-e
star-e merged commit 620d38c into cocos:v4.0.0 Jul 31, 2026
36 checks passed
@troublemaker52025

Copy link
Copy Markdown
Contributor Author

测试方法

  • 打开cocos-test-projects,打包到web或者原生应用
  • 运行到light/lighting场景,观察灯光效果
  • 如果每个box都接收到了光照,则说明修复方案正确

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants