fix planar reflections for editor camera previews - #236
Merged
Conversation
Code Size Check Report
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -45497,9 +45497,9 @@
* @zh 设置probe信息
* @param probe
* @param frameBuffer
*/
- setUsageInfo(probe: renderer.scene.ReflectionProbe, frameBuffer: gfx.Framebuffer): void;
+ setUsageInfo(probe: renderer.scene.ReflectionProbe, frameBuffer: gfx.Framebuffer, reflectionCamera?: renderer.scene.Camera): void;
destroy(): void;
clearFramebuffer(camera: renderer.scene.Camera): void;
render(camera: renderer.scene.Camera): void;
activate(pipeline: ForwardPipeline, flow: ReflectionProbeFlow): void;
|
Contributor
Author
|
@cocos-robot run test cases |
|
@xubing0906, Please check the result of
Task Details |
|
@xubing0906, Please check the result of
Task Details |
|
@xubing0906, Please check the result of
Task Details
|
|
@xubing0906, Please check the result of
Task Details |
|
@xubing0906, Please check the result of
Task Details
|
|
@xubing0906, Please check the result of
Task Details |
Contributor
Author
|
测试方式，打开cocos-test-projects工程的planar-reflection-probe场景，点击场景树的Main Camera节点，观察右下角的预览小窗 |
…review Legacy ReflectionProbeFlow was calling renderPlanarReflection() for PREVIEW cameras, which overwrites the main probe camera state and can corrupt Scene View / Game View reflections. Switch to renderPreviewPlanarReflection() and pass the isolated reflection camera through the stage and queue chain.
|
@xubing0906, Please check the result of
Task Details |
|
@xubing0906, Please check the result of
Task Details |
Contributor
Author
|
@cocos-robot run-test-cases-custom |
|
@xubing0906, Please check the result of
Task Details
|
|
@xubing0906, Please check the result of
Task Details
|
Contributor
Author
|
@cocos-robot run test cases |
|
@xubing0906, Please check the result of
Task Details |
|
@xubing0906, Please check the result of
Task Details |
star-e
approved these changes
Aug 17, 2026
jk20012001
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: cocos/cocos-engine#18085
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: