Skip to content

fix(vulkan): fix split barrier events and general barrier submission - #240

Merged
star-e merged 1 commit into
cocos:v4.0.0from
VanityNie:feature/nym
Aug 7, 2026
Merged

fix(vulkan): fix split barrier events and general barrier submission#240
star-e merged 1 commit into
cocos:v4.0.0from
VanityNie:feature/nym

Conversation

@VanityNie

Copy link
Copy Markdown
Contributor

Re: #

Changelog

  • 修复 Vulkan buffer split barrier 的 event 判断错误。

    • 修正 missed 的判断逻辑,使其正确表示 buffer 是否缺少对应的 barrier event。
  • 修复 Vulkan GeneralBarrier 未提交的问题。

    • pMemoryBarrier 纳入 vkCmdPipelineBarrier 的调用条件。
    • 根据 pMemoryBarrier 是否存在,正确设置 memoryBarrierCount

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@VanityNie

Copy link
Copy Markdown
Contributor Author

@cocos-robot run test cases

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1014561 bytes 1014561 bytes ✅ 0 bytes
2D All (legacy pipeline) 2682237 bytes 2682237 bytes ✅ 0 bytes
2D All (new pipeline) 2774076 bytes 2774076 bytes ✅ 0 bytes
(2D + 3D) All 10031391 bytes 10031391 bytes ✅ 0 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16867805 bytes 16867805 bytes ✅ 0 bytes

Interface Check Report

This pull request does not change any public interfaces !

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

@VanityNie, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL
ios PASS PASS PASS
mac PASS PASS PASS

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

@VanityNie, Please check the result of run test cases:

Task Details

@star-e
star-e merged commit 0a21bb9 into cocos:v4.0.0 Aug 7, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants