fix(legacy): sphere light has not lighting at LDR mode - #243
Merged
star-e merged 1 commit intoAug 7, 2026
Conversation
Contributor
Author
|
@cocos-robot run test cases |
troublemaker52025
requested review from
jk20012001 and
star-e
and
a lite review from Copilot
August 4, 2026 09:07
jk20012001
approved these changes
Aug 4, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes a rendering bug in LDR mode for legacy light types by adding missing luminanceLDR getters so that code reading the property (e.g., UBO packing) no longer receives undefined (which can propagate as NaN).
Changes:
- Add
get luminanceLDR()toSphereLightso LDR luminance reads correctly. - Add
get luminanceLDR()toPointLightfor the same reason and consistency with other light implementations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cocos/render-scene/scene/sphere-light.ts | Adds the missing luminanceLDR getter so LDR luminance reads don’t return undefined. |
| cocos/render-scene/scene/point-light.ts | Adds the missing luminanceLDR getter to prevent undefined reads and align with other light classes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Code Size Check Report
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -13006,8 +13006,9 @@
/**
* @en The luminance of the light source in LDR mode
* @zh LDR 模式下光源的亮度
*/
+ get luminanceLDR(): number;
set luminanceLDR(value: number);
/**
* @en The AABB bounding box of the lighting area
* @zh 受光源影响范围的 AABB 包围盒
@@ -13181,8 +13182,9 @@
/**
* @en The luminance of the light source in LDR mode.
* @zh LDR 模式下光源的亮度。
*/
+ get luminanceLDR(): number;
set luminanceLDR(value: number);
/**
* @en The AABB bounding box of the lighting area.
* @zh 受光源影响范围的 AABB 包围盒。
|
Contributor
Author
测试方法:
*测试场景需要合并 |
Contributor
Author
star-e
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: