Skip to content

fix punctual lights visibility issue with custom pipeline (#270) - #272

Merged
star-e merged 1 commit into
cocos:v4.0.0from
jk20012001:4.0.0
Aug 15, 2026
Merged

fix punctual lights visibility issue with custom pipeline (#270)#272
star-e merged 1 commit into
cocos:v4.0.0from
jk20012001:4.0.0

Conversation

@jk20012001

@jk20012001 jk20012001 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Re: #

Changelog

  • 自定义管线中没有处理light visibility导致光源无法筛选作用的物体类别。

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@jk20012001
jk20012001 requested a review from star-e August 14, 2026 09:34
@star-e

star-e commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

@cocos-robot run-test-cases-custom

@github-actions

Copy link
Copy Markdown

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1015084 bytes 1015084 bytes ✅ 0 bytes
2D All (legacy pipeline) 2682815 bytes 2682815 bytes ✅ 0 bytes
2D All (new pipeline) 2774652 bytes 2774788 bytes ⚠️ +136 bytes
(2D + 3D) All 10032071 bytes 10032207 bytes ⚠️ +136 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16868489 bytes 16868625 bytes ⚠️ +136 bytes

Interface Check Report

This pull request does not change any public interfaces !

@github-actions

Copy link
Copy Markdown

@jk20012001, Please check the result of run test cases:

Task Details

@github-actions

Copy link
Copy Markdown

@jk20012001, Please check the result of run test cases:

Task Details

@github-actions

Copy link
Copy Markdown

@jk20012001, Please check the result of run test cases:

Task Details

@github-actions

Copy link
Copy Markdown

@jk20012001, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
windows PASS PASS PASS
android PASS PASS FAIL BuildTimeConstantsTest
wechatgame PASS PASS FAIL particle-compare,BuildTimeConstantsTest

@star-e
star-e merged commit 2d003cc into cocos:v4.0.0 Aug 15, 2026
49 of 50 checks passed
@jk20012001

jk20012001 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

测试流程
打开cocos-test-projects/light/lighting2 场景
查看左边三个物体,分别被红、绿、蓝动态灯光照亮,没有叠加或串色
查看右边三个物体,是有叠加照亮的烘焙颜色,如图所示
image

和图片一样说明该修复正确

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants