Skip to content

fix: resolve ClangTidy Android CI failure caused by DebugView.h warnings - #282

Closed
star-e with Copilot wants to merge 3 commits into
v4.0.0from
copilot/fix-clangtidy-android-job
Closed

fix: resolve ClangTidy Android CI failure caused by DebugView.h warnings#282
star-e with Copilot wants to merge 3 commits into
v4.0.0from
copilot/fix-clangtidy-android-job

Conversation

Copilot AI commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

PatriceJiang/clang-tidy-action was crashing with Offset out of range! because clang-tidy generated fix entries in clang-fixes.yaml with byte offsets beyond the file boundaries — triggered by two warnings in DebugView.h.

Changes

  • native/cocos/renderer/pipeline/DebugView.h
    • Remove else/else if after return in getType() (readability-else-after-return)
    • Remove duplicate private: access specifier (readability-redundant-access-specifiers)
// Before
if (_singleMode != DebugViewSingleType::NONE) {
    return RenderingDebugViewType::SINGLE;
} else if (!_lightingWithAlbedo || _csmLayerColoration) {   // ← else-after-return
    return RenderingDebugViewType::COMPOSITE_AND_MISC;
} else { ... }

// After
if (_singleMode != DebugViewSingleType::NONE) {
    return RenderingDebugViewType::SINGLE;
}
if (!_lightingWithAlbedo || _csmLayerColoration) {
    return RenderingDebugViewType::COMPOSITE_AND_MISC;
}

The redundant second private: block was merged into the existing one by removing the duplicate specifier.

Co-authored-by: star-e <13654656+star-e@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job ClangTidy Android fix: resolve ClangTidy Android CI failure caused by DebugView.h warnings Aug 15, 2026
Copilot AI requested a review from star-e August 15, 2026 17:29
Co-authored-by: star-e <13654656+star-e@users.noreply.github.com>
@star-e star-e closed this Aug 15, 2026
@star-e
star-e deleted the copilot/fix-clangtidy-android-job branch September 4, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants