fix(ui):keep destroy widgets out of the widget's active list - #302
Merged
Conversation
Code Size Check Report
Interface Check ReportThis pull request does not change any public interfaces ! |
|
@LinYunMo, Please check the result of
Task Details |
|
@LinYunMo, Please check the result of
Task Details |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: cocos/cocos-engine#18893
Changelog
activeWidgetscould keep widgets that have already been destroyed, sorefreshScenecalledalign()withwidget.node === null(reset byCCObject._destruct) and threw every frame.Entries got in through
visitNode, which collected widgets bywidget.enabledalone - a flag that stays true after
destroy(). Entries only got out throughWidget.onDisable, whichdisableCompskips unless the component was enabledby the scheduler (
IsOnEnableCalled).visitNodenow rejects widgets that are already marked for destruction.Widget.onDestroyunregisters as well, covering widgets that were collectedwhile still valid but never got
onDisable.Continuous Integration
This pull request:
Compatibility Check
This pull request: