Skip to content

fix(webgl): correct buffer-to-texture extent height calculation - #303

Merged
star-e merged 1 commit into
cocos:v4.0.0from
VanityNie:feature/nym
Aug 21, 2026
Merged

fix(webgl): correct buffer-to-texture extent height calculation#303
star-e merged 1 commit into
cocos:v4.0.0from
VanityNie:feature/nym

Conversation

@VanityNie

Copy link
Copy Markdown
Contributor

Use regionTexExtentHeight instead of regionTexExtentWidth when calculating copied texture extents to prevent incorrect row and slice strides.

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Use regionTexExtentHeight instead of regionTexExtentWidth when calculating copied texture extents to prevent incorrect row and slice strides.
@github-actions

Copy link
Copy Markdown

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1015435 bytes 1015436 bytes ⚠️ +1 bytes
2D All (legacy pipeline) 2683166 bytes 2683167 bytes ⚠️ +1 bytes
2D All (new pipeline) 2775425 bytes 2775426 bytes ⚠️ +1 bytes
(2D + 3D) All 10032867 bytes 10032868 bytes ⚠️ +1 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16869285 bytes 16869286 bytes ⚠️ +1 bytes

Interface Check Report

This pull request does not change any public interfaces !

@star-e

star-e commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

@cocos-robot run test cases

@github-actions

Copy link
Copy Markdown

@VanityNie, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL graphics-continuous-filling
ios PASS PASS PASS
mac PASS PASS PASS

@github-actions

Copy link
Copy Markdown

@VanityNie, Please check the result of run test cases:

Task Details

@star-e
star-e merged commit 825362f into cocos:v4.0.0 Aug 21, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants