fix(rendering): compute render pass merge info in render graph order - #314
Merged
star-e merged 1 commit intoAug 29, 2026
Merged
Conversation
In debug mode, pass hashes are generated while traversing the resource graph during compilation, so the render-pass merge bookkeeping (needBeginRP/needEndRP) can be computed in a different order from the actual execution order. When passes are reused, this can cause draw commands to be recorded outside a render pass and rejected by the validator. Compute hashes after compilation by iterating the render graph vertices in execution order, and only include valid raster passes in debug mode. Refs cocos#156
Code Size Check Report
Interface Check ReportThis pull request does not change any public interfaces ! |
Contributor
Author
star-e
approved these changes
Aug 29, 2026
Contributor
|
@cocos-robot run-test-cases-custom |
|
@VanityNie, Please check the result of
Task Details
|
|
@VanityNie, Please check the result of
Task Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In debug mode, pass hashes are generated while traversing the resource graph during compilation, so the render-pass merge bookkeeping (needBeginRP/needEndRP) can be computed in a different order from the actual execution order. When passes are reused, this can cause draw commands to be recorded outside a render pass and rejected by the validator.
Compute hashes after compilation by iterating the render graph vertices in execution order, and only include valid raster passes in debug mode.
Refs #156
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: