Comprehensive test suite improvements and CI fix (#183)

* Fix test infrastructure from previous session

- Suppress PDO::MYSQL_ATTR_SSL_CA deprecation on PHP 8.5
- Enable Unit test suite in phpunit.xml (was commented out)
- Fix ReactionFactory to use User::factory() instead of hardcoded IDs

* Fix existing test issues

- Add signIn() helper using actingAs() for faster auth in tests
- Remove duplicate signInAndReturnToken() from LessonTest
- Fix CodandoWebhookTest to not depend on seeded data
- Un-skip WorkshopTest shape test (was using wrong field names)
- Add missing @test annotation on workshop soon list test
- Refactor LessonTest to use signIn() instead of real HTTP login

* Add factory states for deterministic tests

- ChallengeFactory: default to draft, add published/draft/soon states
- WorkshopFactory: default to draft, add published/draft/soon states
- UserFactory: add pro() and admin() states
- SubscriptionFactory: add active/expired/canceled states
- LessonFactory: add forWorkshop/forChallenge states

* Extract reusable test traits

- Create BuildsPagarmePayloads trait from PagarmeWebhookFullTest
- Create CreatesSubscription trait for subscription test setup
- Refactor PagarmeWebhookFullTest to use shared trait

* Add high-priority feature tests

- DashboardTest: auth, name/password/linkedin/avatar/settings changes
- CertificateTest: create, duplicate prevention, show by id/slug
- TrackTest: list published/soon, exclude draft, show by slug
- RankingTest: list, monthly filter, admin exclusion
- LeadsTest: create, validation, duplicate prevention

* Add medium-priority feature tests

- InstructorTest: list, show by slug, workshops relationship
- CalendarTest: events endpoint, date range filtering
- TrackableTest: auth, mark complete, toggle completion

* Add unit tests for models, mail, and notifications

- UserTest: subscribeToPlan, upgrade/downgrade pro, admin check
- SubscriptionTest: translated status/payment, changeStatus
- CertificateTest: validateCertifiable method
- MailableTest: all 7 mail classes (subjects, payment method views)
- NotificationTest: certificate published, comment notifications

* Add listener, observer, and service tests

- AwardPointsTest: all 5 event types (complete, join, fork, reaction)
- CertificateObserverTest: status change dispatches event
- DiscordServiceTest: send message, embeds, test channel routing

* Fix CI pipeline

- Upgrade MySQL 5.7 to 8.0
- Add missing migration step before running tests
- Fix APP_ENV to testing (was ci, broke Discord service mock)
- Add BCRYPT_ROUNDS=4 for faster CI
- Fix deprecated MAIL_DRIVER/QUEUE_DRIVER to MAIL_MAILER/QUEUE_CONNECTION
- Add TELESCOPE_ENABLED=false
- Update actions/checkout to v4, shivammathur/setup-php to v2
- Remove deprecated --no-suggest Composer flag
- Split tests and deploy into separate jobs

* Add MocksExternalServices trait

Reusable trait for mocking GitHub, Discord, and other external HTTP
calls in tests.

Author: icaroharry

.env.github

@@ -1,7 +1,8 @@
-APP_ENV=ci
+APP_ENV=testing
 APP_KEY=
 APP_DEBUG=true
 APP_URL=https://localhost
+APP_FRONTEND_URL=https://codante.io
 
 LOG_CHANNEL=stack
 
@@ -12,9 +13,11 @@ DB_DATABASE=codante_test
 DB_USERNAME=user
 DB_PASSWORD=password
 
+BCRYPT_ROUNDS=4
+
 SESSION_DRIVER=array
 CACHE_DRIVER=array
+QUEUE_CONNECTION=sync
+MAIL_MAILER=array
 
-QUEUE_DRIVER=sync
-
-MAIL_DRIVER=log
+TELESCOPE_ENABLED=false

.github/workflows/main.yml

@@ -5,13 +5,13 @@ on:
     branches: [main]
 
 jobs:
-  deploy:
-    name: deploy
+  tests:
+    name: Tests
     runs-on: ubuntu-latest
 
     services:
       mysql:
-        image: mysql:5.7
+        image: mysql:8.0
         env:
           MYSQL_DATABASE: codante_test
           MYSQL_USER: user
@@ -22,36 +22,57 @@ jobs:
         options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Setup PHP
-        uses: shivammathur/setup-php@master
+        uses: shivammathur/setup-php@v2
         with:
           php-version: 8.3
           extensions: mbstring, bcmath, zip
           tools: composer:v2
+          coverage: none
 
       - name: Composer install
-        run: composer install --prefer-dist --no-interaction --no-suggest
-
-      # - name: Check code style (Laravel Pint)
-      #   run: ./vendor/bin/pint --test
+        run: composer install --prefer-dist --no-interaction
 
       - name: Boot Laravel application
         run: |
           cp .env.github .env
           php artisan key:generate
           php artisan --version
 
+      - name: Run migrations
+        run: php artisan migrate --force
+        env:
+          DB_PORT: ${{ job.services.mysql.ports[3306] }}
+
       - name: Execute tests (Unit and Feature tests) via PHPUnit
         run: vendor/bin/phpunit
         env:
           DB_PORT: ${{ job.services.mysql.ports[3306] }}
 
+  deploy:
+    name: Deploy
+    runs-on: ubuntu-latest
+    needs: tests
+
+    if: github.ref == 'refs/heads/main'
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: 8.3
+          tools: composer:v2
+          coverage: none
+
+      - name: Composer install
+        run: composer install --prefer-dist --no-interaction
+
       - name: Setup Deployer
         uses: deployphp/action@master
         with:
           private-key: ${{ secrets.SSH_PRIVATE_KEY }}
-
-          ## known-hosts: ${{ secrets.SSH_KNOWN_HOSTS }}
           dep: deploy -v

config/database.php

@@ -59,7 +59,7 @@
             'strict' => true,
             'engine' => null,
             'options' => extension_loaded('pdo_mysql') ? array_filter([
-                PDO::MYSQL_ATTR_SSL_CA => env('MYSQL_ATTR_SSL_CA'),
+                @constant('PDO::MYSQL_ATTR_SSL_CA') ?: 1009 => env('MYSQL_ATTR_SSL_CA'),
             ]) : [],
         ],
 

database/factories/ChallengeFactory.php

@@ -23,17 +23,27 @@ public function definition(): array
             'image_url' => fake()->imageUrl(640, 480, 'Avatar', true),
             'video_url' => 'https://player.vimeo.com/video/22331996',
             'slug' => fake()->slug(4),
-            'status' => fake()->randomElement([
-                'draft',
-                'published',
-                'soon',
-                'archived',
-            ]),
+            'status' => 'draft',
             'difficulty' => fake()->numberBetween(1, 3),
             'duration_in_minutes' => fake()->numberBetween(60, 300),
             'repository_name' => fake()->url(),
             'position' => fake()->numberBetween(1, 100),
-            'featured' => fake()->randomElement(['landing', null, 'new']),
+            'featured' => null,
         ];
     }
+
+    public function published(): static
+    {
+        return $this->state(fn () => ['status' => 'published']);
+    }
+
+    public function draft(): static
+    {
+        return $this->state(fn () => ['status' => 'draft']);
+    }
+
+    public function soon(): static
+    {
+        return $this->state(fn () => ['status' => 'soon']);
+    }
 }

database/factories/LessonFactory.php

@@ -2,6 +2,8 @@
 
 namespace Database\Factories;
 
+use App\Models\Challenge;
+use App\Models\Workshop;
 use Illuminate\Database\Eloquent\Factories\Factory;
 
 /**
@@ -23,6 +25,24 @@ public function definition(): array
             'duration_in_seconds' => fake()->numberBetween(60, 3600),
             'video_url' => 'https://player.vimeo.com/video/112836958',
             'slug' => fake()->slug(4),
+            'lessonable_id' => Challenge::factory(),
+            'lessonable_type' => Challenge::class,
         ];
     }
+
+    public function forWorkshop(?Workshop $workshop = null): static
+    {
+        return $this->state(fn () => [
+            'lessonable_id' => $workshop?->id ?? Workshop::factory(),
+            'lessonable_type' => Workshop::class,
+        ]);
+    }
+
+    public function forChallenge(?Challenge $challenge = null): static
+    {
+        return $this->state(fn () => [
+            'lessonable_id' => $challenge?->id ?? Challenge::factory(),
+            'lessonable_type' => Challenge::class,
+        ]);
+    }
 }

database/factories/ReactionFactory.php

@@ -18,7 +18,7 @@ public function definition(): array
     {
         return [
             'reaction' => $this->faker->randomElement(['like', 'fire', 'rocket', 'exploding-head']),
-            'user_id' => $this->faker->numberBetween(1, 10),
+            'user_id' => \App\Models\User::factory(),
         ];
     }
 }

database/factories/SubscriptionFactory.php

@@ -21,7 +21,29 @@ public function definition()
             'starts_at' => Carbon::now(), // Default start date
             'ends_at' => Carbon::now()->addMonth(),
             'acquisition_type' => 'paid',
-            // ...other fields...
         ];
     }
+
+    public function active(): static
+    {
+        return $this->state(fn () => [
+            'status' => 'active',
+            'starts_at' => Carbon::now(),
+            'ends_at' => Carbon::now()->addMonth(),
+        ]);
+    }
+
+    public function expired(): static
+    {
+        return $this->state(fn () => [
+            'status' => 'active',
+            'starts_at' => Carbon::now()->subMonths(2),
+            'ends_at' => Carbon::now()->subDay(),
+        ]);
+    }
+
+    public function canceled(): static
+    {
+        return $this->state(fn () => ['status' => 'canceled']);
+    }
 }

database/factories/UserFactory.php

@@ -41,4 +41,14 @@ public function unverified(): static
             ]
         );
     }
+
+    public function pro(): static
+    {
+        return $this->state(fn () => ['is_pro' => true]);
+    }
+
+    public function admin(): static
+    {
+        return $this->state(fn () => ['is_admin' => true]);
+    }
 }

database/factories/WorkshopFactory.php

@@ -24,13 +24,28 @@ public function definition(): array
             'image_url' => fake()->imageUrl(640, 480, 'Avatar', true),
             'video_url' => 'https://player.vimeo.com/video/4812350',
             'slug' => fake()->slug(4),
-            'status' => fake()->randomElement(['draft', 'published', 'soon', 'archived']),
+            'status' => 'draft',
             'is_standalone' => fake()->boolean(),
             'difficulty' => fake()->numberBetween(1, 3),
             'duration_in_minutes' => fake()->numberBetween(60, 300),
             'instructor_id' => Instructor::factory(),
-            'featured' => fake()->randomElement(['landing', null, 'new']),
+            'featured' => null,
             'published_at' => fake()->dateTimeBetween('-1 year', 'now'),
         ];
     }
+
+    public function published(): static
+    {
+        return $this->state(fn () => ['status' => 'published']);
+    }
+
+    public function draft(): static
+    {
+        return $this->state(fn () => ['status' => 'draft']);
+    }
+
+    public function soon(): static
+    {
+        return $this->state(fn () => ['status' => 'soon']);
+    }
 }

phpunit.xml

@@ -1,9 +1,9 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.5/phpunit.xsd" bootstrap="vendor/autoload.php" colors="true">
   <testsuites>
-    <!-- <testsuite name="Unit">
+    <testsuite name="Unit">
       <directory suffix="Test.php">./tests/Unit</directory>
-    </testsuite> -->
+    </testsuite>
     <testsuite name="Feature">
       <directory suffix="Test.php">./tests/Feature</directory>
     </testsuite>