Repository navigation
feat: add BYPASS_ORDER_PRECAUTIONS for API → Precautions - #72
Merged
Merged
Conversation
BYPASS_ORDER_PRECAUTIONS=yes ticks Gateway's "Bypass Order Precautions for API Orders" box under Configure → Settings → API → Precautions, no unticks it, and unset leaves it as it is (issue #68). Some accounts show the box as "Bypass Order and Ticket Precautions for API Orders and Tickets"; the controller asks JSTATE which label is showing and sets that one. The box is read back after OK like Read-Only API: Verified, or ALERT_CONFIG_NOT_APPLIED with env_var=BYPASS_ORDER_PRECAUTIONS if Gateway didn't keep it or the box couldn't be set. A value that isn't one of yes/no, true/false, on/off, 1/0 gets a WARNING, for READ_ONLY_API too. scripts/ibc_config_to_env.py maps IBC's BypassOrderPrecautions.
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds
BYPASS_ORDER_PRECAUTIONS(#68):yesticks Gateway's Bypass Order Precautions for API Orders box under Configure → Settings → API → Precautions,nounticks it, unset leaves it as it is.Why
IBC's
BypassOrderPrecautionshad no controller equivalent, so API orders that trip an order precaution needed the box ticked by hand over VNC and a settings volume to keep it.How it works:
JSTATEwhich label is showing (reads only, quietly) and sets that one withJCHECK.Verified: Bypass Order Precautions for API Orders reads back as True, orALERT_CONFIG_NOT_APPLIED ... env_var=BYPASS_ORDER_PRECAUTIONS reason="Gateway did not retain the value after OK; ...".READ_ONLY_APItoo.scripts/ibc_config_to_env.pymapsBypassOrderPrecautions.Gateway 10.50.1f has text for a "deactivate these precautions for all API orders?" confirmation, but it is never shown; ticking the box only sets the value. On a paper 10.50.1f Gateway with fresh settings,
BYPASS_ORDER_PRECAUTIONS=yes,READ_ONLY_API=noandAUTO_RESTART_TIME, the box was ticked, kept after OK and read back as on, alongside the other settings. The Lock and Exit drill's fixture gains a Precautions page with both labels.Checklist
make clean && make && make testpasses (full unit suite green)docs/OBSERVABILITY.mdupdated (if touching ALERT tokens,/health, or env vars listed there)docs/FROM_IBC.mdupdated (if changing anything that maps to an IBC key)docs/UPGRADING.mdgets a new### vX.Y.Zsection if the change is operator-visible