Repository navigation
Move inspector and canvas text logic into VisuStructCore - #12
Merged
Merged
Conversation
IO-prefix handling, keyword stripping for the line editor, quote normalization and for-loop field handling move from ContentView into VisuStructLineEditorText; the canvas display text (added keywords, until -> while, keyword split) moves into VisuStructDiagramText. Both are now covered by swift test. Removes two unused helpers (stripLineEditorPrefix, stripKeywordPrefix). No behavior change. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cp4EQgFQyGbM8MVLiWbJKQ
code4teaching
marked this pull request as ready for review
October 18, 2026 22:17
- VisuStructCore: VisuStructEditHistory (undo/redo stacks, 80-step limit) and VisuStructDocumentEditing.sanitizedSelection, with tests. - DiagramSheetTab keeps a VisuStructEditHistory instead of two arrays. - DiagramSheetTabsModel+Editing: currentTab, updateCurrentTab, commitDocument, resetHistoryAndDocument, undo, redo, selectAndClearError, setErrorOnCurrentTab. - ContentView uses these instead of copying tabs by hand at each site. No behavior change intended. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cp4EQgFQyGbM8MVLiWbJKQ
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cp4EQgFQyGbM8MVLiWbJKQ
The engine, play/pause task, input text and the simulation mode flag move from ContentView @State into an @observable SimulationController. The step delay and highlight mode are read from UserDefaults at each step, as the @AppStorage values were before. No behavior change intended. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cp4EQgFQyGbM8MVLiWbJKQ
- Palette/PaletteActionList.swift: palette rows, drag preview and the action buttons below; actions come in as closures. - Simulation/SimulationDetailView.swift: canvas plus state panel layout for simulation mode, driven by SimulationController. - ContentView keeps the action logic (toggleSimulationMode, openCodeGenerator) and the simulation canvas. No behavior change intended. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cp4EQgFQyGbM8MVLiWbJKQ
- VisuStructCore: VisuStructDocumentEditing.multiwayAncestorPath and caseIndex(of:inMultiwayAt:), with tests. - Inspector/InspectorElementHints.swift: line editor placeholder and condition hint line per element type. - Remove the unused statementIOModeIfApplicable(). No behavior change intended. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cp4EQgFQyGbM8MVLiWbJKQ
The four export actions in ContentView each rendered the diagram and mapped errors themselves. Export/DiagramExporter.swift now does that; ContentView only stores the share payloads it returns. No behavior change intended. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cp4EQgFQyGbM8MVLiWbJKQ
- DiagramCanvasView.swift: inputs, state, layout and body, clipboard. - DiagramCanvasDropZones.swift: drop bands, tap insert targets and applying drops. - DiagramCanvasRenderer.swift: Canvas drawing of cells, lines and text. The two new files are extensions of DiagramCanvasView, so members they share lose their `private`. Code is moved unchanged otherwise. No behavior change intended. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cp4EQgFQyGbM8MVLiWbJKQ
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cp4EQgFQyGbM8MVLiWbJKQ
Carries the portrait simulation layout from main into SimulationDetailView.swift. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cp4EQgFQyGbM8MVLiWbJKQ
Carries the VoiceOver block labels from main into DiagramCanvasDropZones.swift. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cp4EQgFQyGbM8MVLiWbJKQ
# Conflicts: # VisuStruct-iOS/VisuStructXcodeOpen/VisuStruct/ContentView.swift
Split DiagramCanvasView into view, drop zones and renderer
Bundle PNG, file, PDF and print export in DiagramExporter
Move inspector hints and Fallauswahl path helpers out of ContentView
Extract PaletteActionList and SimulationDetailView from ContentView
Move simulation state and controls into SimulationController
Move undo/redo and tab editing out of ContentView
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Holger · project thread
Before: the string handling behind the inspector's line editor (input:/output: prefixes, keyword stripping while typing, typographic quotes, for-loop fields) and the canvas display text (added
if/while/switch,until→while, bold keyword split) lived as private functions inContentViewandDiagramCanvasView, untested.After: the same logic lives in
VisuStructCoreasVisuStructLineEditorTextandVisuStructDiagramText, with tests. The views call it. No behavior change.ContentViewloses ~140 lines,DiagramCanvasView~70. Two helpers that had no callers (stripLineEditorPrefix,stripKeywordPrefix) are removed.StatementIOModeis now a typealias for the core enum.How: functions moved verbatim (renamed to Swift API style), placeholder texts for empty tiles stay in the canvas because they are localized. Step 2 of the refactoring plan; stacked on the synchronized-folder PR.
Generated by Claude Code