Track the ack-script container by name; time limits on the moved and attached calls (#189)

Review round 50: agent-supervisor's label-less ack-script container is tracked
by name before its create and removed by afterAll; runner-workspace's docker
helper, which now runs calls this branch moved out of a try, takes CLIENT_LIMIT;
the seccomp probe and agent-network's attached helper runs are killed with
SIGKILL at their limit, as an attached run forwards SIGTERM; the killed-create
test's listing reports its own failure.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: mchwang

test/agent-container.test.ts

@@ -973,8 +973,11 @@ describe('real Docker agent isolation', () => {
     ].join('\n');
     const created = await withDockerShim(['network', 'create'], foreign, () =>
       createVendorNetwork(invocation(data.clone, 'planning'), imageId, allocationId).then(() => undefined, error => error));
-    const left = spawnSync('docker', ['network', 'ls', '--quiet', '--filter', `label=io.codeboost.allocation=${allocationId}`],
-      { encoding: 'utf8', timeout: 60_000, killSignal: 'SIGKILL' }).stdout?.trim() ?? '';
+    const listing = spawnSync('docker', ['network', 'ls', '--quiet', '--filter', `label=io.codeboost.allocation=${allocationId}`],
+      { encoding: 'utf8', ...CLIENT_LIMIT });
+    // A listing that failed fails here with its cause, as main's helper did.
+    expect(listing.status, listing.error?.message ?? (listing.signal ? `killed by ${listing.signal}` : listing.stderr)).toBe(0);
+    const left = listing.stdout.trim();
     expect(created).toBeInstanceOf(VendorNetworkCreationCleanupError);
     const cleanup = (created as VendorNetworkCreationCleanupError).errors[1] as AggregateError;
     expect(cleanup.errors.map(error => (error as Error).message)).toEqual(['Refused to remove unowned vendor network.']);
@@ -2639,7 +2642,7 @@ describe('real Docker agent isolation', () => {
     containers.add(name);
     const result = spawnSync('docker', ['run', '--rm', '--name', name, '--read-only', '--user', '10001:10001', '--cap-drop=ALL',
       '--security-opt=no-new-privileges', '--security-opt=seccomp=unconfined', '--network=none', imageId, 'true'],
-      { encoding: 'utf8', timeout: 60_000 });
+      { encoding: 'utf8', ...CLIENT_LIMIT });
     expect(result.status).toBe(78);
     expect(result.stderr).toContain('seccomp syscall filter must be enforced');
   }, 60_000);

test/agent-network.test.ts

@@ -27,7 +27,7 @@ const docker = (...args: string[]) => execFileSync('docker', args, {
 const curl = (url: string, direct = false) => spawnSync('docker', ['run', '--rm', ...fileLabel, `--network=${network.name}`,
   '--env', `HTTPS_PROXY=${network.proxyUrl}`, ...(direct ? ['--env', 'NO_PROXY=*'] : []),
   '--entrypoint', 'curl', imageId, '--silent', '--show-error', '--output', '/dev/null', '--write-out', '%{http_code}',
-  '--max-time', '15', url], { encoding: 'utf8', timeout: 30_000, stdio: ['ignore', 'pipe', 'pipe'] });
+  '--max-time', '15', url], { encoding: 'utf8', timeout: 30_000, killSignal: 'SIGKILL', stdio: ['ignore', 'pipe', 'pipe'] });
 
 beforeAll(async () => {
   imageId = buildAgentImage();
@@ -316,7 +316,7 @@ describe('vendor-only egress', () => {
         "const dns=require('node:dns');dns.setServers(['127.0.0.11']);",
         "dns.resolve4('example.com',(error)=>process.exit(error?0:1));",
         'setTimeout(()=>process.exit(0),3000);',
-      ].join('')], { encoding: 'utf8', timeout: 10_000, stdio: ['ignore', 'pipe', 'pipe'] });
+      ].join('')], { encoding: 'utf8', timeout: 10_000, killSignal: 'SIGKILL', stdio: ['ignore', 'pipe', 'pipe'] });
     expect(result.status).toBe(0);
   }, 30_000);
 
@@ -340,7 +340,7 @@ describe('vendor-only egress', () => {
         '--entrypoint', 'node', imageId, '-e', "require('node:net').createServer(()=>{}).listen(4567,'0.0.0.0');setInterval(()=>{},1000)");
       const result = spawnSync('docker', ['run', '--rm', ...fileLabel, `--network=${other.name}`, '--entrypoint', 'node', imageId,
         '-e', "const s=require('node:net').connect(4567,'codeboost-peer');s.on('connect',()=>process.exit(0));s.on('error',()=>process.exit(1));setTimeout(()=>process.exit(2),3000)"],
-      { encoding: 'utf8', timeout: 10_000, stdio: ['ignore', 'pipe', 'pipe'] });
+      { encoding: 'utf8', timeout: 10_000, killSignal: 'SIGKILL', stdio: ['ignore', 'pipe', 'pipe'] });
       expect(result.status).not.toBe(0);
     } finally {
       spawnSync('docker', ['rm', '--force', peer], { stdio: 'ignore' });

test/agent-supervisor.test.ts

@@ -30,6 +30,8 @@ const testOwner = (attemptId = 'fixture') => ({ runnerOwner: TEST_RUNNER_OWNER,
 
 const roots: string[] = [], profiles: ContainerProfile[] = [];
 const allocations: ReturnType<typeof prepareTaskFilesystems>[] = [];
+/** Label-less containers, by name, removed in afterAll should their create land after their test's finally (#189). */
+const unlabelled = new Set<string>();
 let imageId = '';
 const git = fixtureGit;
 
@@ -70,6 +72,7 @@ async function profile(data: ReturnType<typeof fixture>, probe: IsolationProbe,
 beforeAll(async () => { imageId = buildAgentImage(); }, 10 * 60_000);
 afterAll(async () => {
   try {
+    for (const name of unlabelled) removeByName('container', name, 'afterAll');
     for (const profile of profiles) await disposeContainerProfile(profile);
     for (const allocation of allocations.reverse()) removeTaskFilesystems(allocation);
     for (const root of roots.reverse()) {
@@ -653,8 +656,11 @@ describe('container invocation supervisor', () => {
   it('writes the deferred output acknowledgement idempotently, repairing a partial one', () => {
     const token = randomUUID(), file = `/run/codeboost-control/collected-${token}`;
     const name = `codeboost-ack-script-${randomUUID()}`;
+    // Tracked before it is made: it has no labels, and a create that lands after its client was killed is never started,
+    // so `--rm` does not apply and only removal by name finds it (#189).
+    unlabelled.add(name);
     try {
-      // Inside the try: the container has no labels, so only the finally below removes it (#189).
+      // Inside the try: the container has no labels, so the finally below removes it, and afterAll by name (#189).
       execFileSync('docker', ['run', '-d', '--rm', '--name', name, '--network', 'none', '--cap-drop=ALL',
         '--security-opt=no-new-privileges', '--user', '10001:10001', '--entrypoint', 'sleep',
         '--tmpfs', '/run/codeboost-control:rw,nosuid,nodev,noexec,size=65536,nr_inodes=16,uid=0,gid=0,mode=0711',

test/runner-workspace.test.ts

@@ -15,7 +15,7 @@ import { attemptRef, openRunnerRepository } from '../runner/runner-repository.ts
 import { ReviewService } from '../runner/review.ts';
 import { Store } from '../runner/store.ts';
 import { createTaskWorkspace } from '../runner/workspace.ts';
-import { removeRunnerObjects, requireRealDocker } from './fixtures/docker-sweep.ts';
+import { CLIENT_LIMIT, removeRunnerObjects, requireRealDocker } from './fixtures/docker-sweep.ts';
 import { fixtureGit as git } from './fixtures/git.ts';
 
 // F2b against the real lane D (#87): each item runs in fresh task storage cloned from the runner-owned repository, an
@@ -43,7 +43,8 @@ afterAll(() => {
     removeRunnerObjects(RUNNER_OWNER);
   }
 }, 7 * 60_000);
-const docker = (...args: string[]) => execFileSync('docker', args, { encoding: 'utf8', stdio: ['ignore', 'pipe', 'pipe'] }).trim();
+const docker = (...args: string[]) => execFileSync('docker', args, { encoding: 'utf8', stdio: ['ignore', 'pipe', 'pipe'],
+  ...CLIENT_LIMIT }).trim();
 
 async function setup(agent: Record<string, string>) {
   const root = mkdtempSync(join(tmpdir(), 'runner-workspace-')); roots.push(root);