Preserve active question state on reload

Author: mchwang

docs/implementation/read-only-review.md

@@ -106,3 +106,5 @@ PR #11 round 9 returned no inline findings and identified shutdown ordering in i
 Current PR validation: 187 unit/integration tests, 32 browser tests, typecheck, and diff checks. Earlier counts above identify the stage when each behavior was added.
 
 The documentation-only review after adding `AGENTS.md` exposed one more concrete lifecycle race: an expired persisted attempt could show Retry while its cancelled provider was still settling. Question polling now exposes whether the local invocation remains active, displays Finishing cancellation, and keeps polling without exposing Retry until settlement. A browser regression advances the persisted clock while leaving the invocation unresolved, then confirms Retry appears only after settlement.
+
+The follow-up review exposed the same active-job marker missing from the initial review response. Reloading during provider settlement could therefore expose Retry and stop polling. Initial loads and action responses now include the marker used by question polling; the browser regression reloads during settlement and confirms Retry remains hidden until the invocation finishes.

test/browser/review.spec.ts

@@ -289,6 +289,7 @@ test('hides Retry until a timed-out invocation has actually settled',async({page
  await expect(page.getByText('Agent · Answering…',{exact:true})).toBeVisible();
  const note=app.service.store.getReviewNotes(config.identity).find(note=>note.text==='Slow question')!;
  app.service.store.finishAnswer(config.identity,note.id,note.answer!.attempt,{status:'failed',error:'Agent timed out. Try again.'});
+ await page.reload();
  await expect(page.getByText('Agent · Finishing cancellation…',{exact:true})).toBeVisible({timeout:10000});
  await expect(page.getByRole('button',{name:'Retry answer',exact:true})).toHaveCount(0);
  settle('Late answer');

web/server.ts

@@ -8,6 +8,7 @@ const publicRoot = new URL('./public/', import.meta.url);
 export async function startServer(config: ReviewConfig, port = 4318, questionAgent?: QuestionAgent) {
   const service = new ReviewService(config), token = randomBytes(32).toString('hex');
   const questions=new Questions(service,questionAgent);
+  const load=()=>{const view=service.load();return {...view,notes:view.notes.map(note=>({...note,answerActive:questions.isRunning(note.id)}))};};
   const server = createServer(async (req, res) => {
     const address = server.address(); const actualPort = address && typeof address !== 'string' ? address.port : port;
     const origin = `http://127.0.0.1:${actualPort}`;
@@ -21,8 +22,8 @@ export async function startServer(config: ReviewConfig, port = 4318, questionAge
         const supplied = req.headers['x-codeboost-token'];
         if (typeof supplied !== 'string' || !/^[a-f0-9]{64}$/.test(supplied) || !timingSafeEqual(Buffer.from(supplied), Buffer.from(token))) { json(403, { error: 'Open the private local URL printed by the CLI.' }); return; }
         if (req.method === 'GET' && path === '/api/settings') { json(200,{questionProvider:service.store.questionProvider()});return; }
-        if (req.method === 'GET' && path === '/api/questions') { json(200,{notes:service.load().notes.map(note=>({...note,answerActive:questions.isRunning(note.id)}))});return; }
-        if (req.method === 'GET' && path === '/api/review') { json(200, service.load()); return; }
+        if (req.method === 'GET' && path === '/api/questions') { json(200,{notes:load().notes});return; }
+        if (req.method === 'GET' && path === '/api/review') { json(200, load()); return; }
         if (req.method !== 'POST' || !['/api/action','/api/settings'].includes(path) || req.headers['content-type'] !== 'application/json') { json(405, { error: 'Unsupported request.' }); return; }
         const chunks: Buffer[] = []; let size = 0;
         for await (const chunk of req) { size += chunk.length; if (size > 16384) { json(413, { error: 'Request too large.' }); return; } chunks.push(chunk); }
@@ -31,15 +32,15 @@ export async function startServer(config: ReviewConfig, port = 4318, questionAge
         if(path==='/api/settings') {service.store.setQuestionProvider(input.questionProvider);json(200,{questionProvider:service.store.questionProvider()});return;}
         if(input.action==='retry-question') {
           const view=service.load();if(input.token!==view.token)throw new Error('Stale review state. Refresh and retry.');
-          questions.start(input.id,view);json(200,service.load());return;
+          questions.start(input.id,view);json(200,load());return;
         }
         const view=service.act(input);
         if(view.createdNoteId && input.kind==='question') {
           try {questions.start(view.createdNoteId,view);} catch(error) {
             // The saved question remains visible and retryable when capacity is reached.
           }
         }
-        json(200,service.load());return;
+        json(200,load());return;
       }
       if (req.method !== 'GET') { json(405, { error: 'Method not allowed.' }); return; }
       const files: Record<string, [string, string]> = { '/': ['index.html', 'text/html'], '/app.js': ['app.js', 'text/javascript'], '/style.css': ['style.css', 'text/css'] };