Close question admission before draining active jobs

Author: mchwang

docs/implementation/read-only-review.md

@@ -88,3 +88,5 @@ PR #11 review round 1 reproduced a stale-poll race: a held question-list respons
 PR #11 review round 2 confirmed the poll fix and raised an outdated-retry issue in its summary. A browser regression reproduced the retry button on an older snapshot; such unanswered questions now instruct the reviewer to ask again against current code. Completed historical answers retain their outdated label. The summary's timeout-reporting concern supplied no concrete failure; timeout and interrupted-lease regressions remain in the validation suite.
 
 PR #11 review round 3 reproduced retrying a locally active job after its persisted lease expires (for example after a clock jump). The manager now rejects a retry while that note is in its running map, before touching the persisted attempt. The regression advances wall time without advancing the deadline timer and checks the original attempt, single invocation, and shutdown cancellation remain intact.
+
+PR #11 review round 4 reproduced new question work entering during shutdown. Questions now marks itself closing synchronously before cancelling/draining jobs; start rejects before any store write or agent invocation, during and after shutdown. The regression failed before the guard and checks that the unstarted note has no attempt recorded.

runner/questions.ts

@@ -18,10 +18,12 @@ export function questionPrompt(view: ReturnType<ReviewService['load']>, note: Re
 }
 export class Questions {
   private running = new Map<string, {controller:AbortController;done:Promise<void>}>();
+  private closing = false;
   private service: ReviewService;
   private agent?: QuestionAgent;
   constructor(service: ReviewService, agent?: QuestionAgent) { this.service=service; this.agent=agent; }
   start(id: string, view: ReturnType<ReviewService['load']>) {
+    if (this.closing) throw new Error('Server is stopping. Reconnect before asking again.');
     if (this.running.has(id)) throw new Error('Agent is already answering this question.');
     const note = view.notes.find(n=>n.id===id && n.kind==='question');
     if (!note) throw new Error('Question not found.');
@@ -46,5 +48,5 @@ export class Questions {
     this.running.set(id,{controller,done});
     void done.finally(()=>this.running.delete(id));
   }
-  async close() {for(const job of this.running.values())job.controller.abort(new Error('Server stopped. Retry the question.'));await Promise.all([...this.running.values()].map(job=>job.done));}
+  async close() {this.closing = true;for(const job of this.running.values())job.controller.abort(new Error('Server stopped. Retry the question.'));await Promise.all([...this.running.values()].map(job=>job.done));}
 }

test/questions.test.ts

@@ -56,3 +56,14 @@ it('does not replace a locally running job when its persisted lease expires',asy
  expect(calls).toBe(1);expect(service.store.getReviewNotes(service.config.identity)[0]!.answer!.attempt).toBe(original);
  await manager.close();expect(signal?.aborted).toBe(true);expect(service.store.getReviewNotes(service.config.identity)[0]!.answer?.error).toMatch(/Server stopped/);
 });
+it('rejects new work as soon as shutdown begins',async()=>{
+ const service=fixture(),first=question(service),second=question(service);let calls=0;
+ const manager=new Questions(service,()=>{calls++;return new Promise(()=>{});});managers.push(manager);
+ manager.start(first.createdNoteId!,first);
+ const closing=manager.close();
+ expect(()=>manager.start(second.createdNoteId!,second)).toThrow(/stopping/);
+ await closing;
+ expect(()=>manager.start(second.createdNoteId!,second)).toThrow(/stopping/);
+ expect(calls).toBe(1);
+ expect(service.store.getReviewNotes(service.config.identity).find(note=>note.id===second.createdNoteId)?.answer).toBeUndefined();
+});