Strengthen edge case validation evidence

Author: mchwang

docs/experiments/review-summary-edge-cases.md

@@ -4,13 +4,13 @@ Validated on 2026-09-23 from `5a2685c`, before selecting real issues for the pla
 
 ## Renamed-file reassignment
 
-A real-Git fixture declares `retry.ts` → `renamed.ts`, then creates an unplanned rename with a content edit. The review exposes unplanned segments on both the removed old path and added new path. Manually assigning every segment to the rename item leaves each segment in scope.
+A real-Git fixture declares `retry.ts` → `renamed.ts`, then creates an unplanned rename with a content edit. The review exposes removed and added text segments with `-` and `+` operations. The fixture resolves the removed side through `oldPath` and the added side through `path`, verifies both declared names, then manually assigns both segments. Each remains in scope.
 
 Result: no defect reproduced. `ReviewService` evaluates a manual assignment against both `path` and `renamed_from`. The integration fixture remains as coverage.
 
 ## Literal pathspec metacharacters
 
-A planting fixture uses the literal declared filename `*.txt` beside a decoy `a.txt`. An owned commit edits the literal file; a later commit removes it while retaining the decoy. The plant helper rejects the history at its declared-file transition check with `Declared plant needs a regular file retained through the remaining history.`
+A planting fixture uses the literal declared filename `*.txt` beside a decoy `a.txt`. An owned commit edits the literal file; a later commit removes it while retaining the decoy. Direct controls prove `git ls-tree ... -- '*.txt'` returns no match and that `ls-tree` rejects `:(glob)` pathspec magic as unsupported. The plant helper then rejects the history at its declared-file transition check with `Declared plant needs a regular file retained through the remaining history.`
 
 Result: no defect reproduced. The decoy does not satisfy the literal transition check. The fixture remains as coverage for Git pathspec metacharacters.
 

test/plant.test.ts

@@ -40,6 +40,8 @@ it('treats metacharacters literally when checking declared-file transitions',()=
  const config={database:join(root,'review.sqlite'),repository,identity,pathIdentity:{caseSensitive:true as const,unicodeNormalization:'none' as const},demo:false};
  const store=new Store(config.database);
  try{store.createPlan(JSON.stringify(plan),'json',{identity,issue:10,baseEntries:['*.txt','a.txt'].map(path=>({path,kind:'file' as const})),pathKey:path=>path,allowedCommands:[]},base,head);store.recordHistory(identity,{revision:1,snapshotId:store.getSnapshot(identity).id},base,head,[{sha:owned,owner:'P1',origin:'owned',sourceSha:null}]);}finally{store.close();}
+ expect(git('ls-tree','--name-only',head,'--','*.txt')).toBe('');
+ expect(()=>git('ls-tree','--name-only',head,'--',':(glob)*.txt')).toThrow(/pathspec magic not supported/);
  expect(()=>plant(config,join(root,'experiment'),{declaredText:'planted',undeclaredText:'outside',undeclaredPath:'extra.txt'})).toThrow(/Declared plant needs a regular file retained/);
 },15000);
 

test/review.test.ts

@@ -25,8 +25,9 @@ it('keeps both sides of a declared rename in scope after manual reassignment',()
  writeFileSync(join(config.repository,'renamed.ts'),'export function delay(attempt: number) {\n  return Math.min(5000, 200 * 2 ** attempt);\n}\n');
  execFileSync('git',['-c','core.hooksPath=/dev/null','add','-A'],{cwd:config.repository});
  execFileSync('git',['-c','core.hooksPath=/dev/null','commit','-m','Rename retry implementation'],{cwd:config.repository,stdio:'pipe'});
- let view=service.load();const candidates=view.segments.filter(segment=>segment.row==='Unplanned'&&['retry.ts','renamed.ts'].includes(segment.path));
- expect(new Set(candidates.map(segment=>segment.path))).toEqual(new Set(['retry.ts','renamed.ts']));
+ let view=service.load();const candidates=view.segments.filter(segment=>segment.row==='Unplanned'&&segment.kind==='text'&&['-','+'].includes(segment.operation)&&['retry.ts','renamed.ts'].includes(segment.operation==='-'?segment.oldPath??segment.path:segment.path));
+ expect(new Set(candidates.map(segment=>segment.operation))).toEqual(new Set(['-','+']));
+ expect(new Set(candidates.map(segment=>segment.operation==='-'?segment.oldPath??segment.path:segment.path))).toEqual(new Set(['retry.ts','renamed.ts']));
  for(const candidate of candidates){view=service.act({action:'assign',key:candidate.key,item:'P1',token:view.token});expect(view.segments.find(segment=>segment.key===candidate.key)?.scope).toBe('in-scope');}
 });
 it('persists bounded per-item notes without creating a plan revision',()=>{