Ignore stale question polls after newer review actions

Author: mchwang

docs/implementation/read-only-review.md

@@ -82,3 +82,5 @@ Answer scrolling: when an asynchronous answer or failure arrives, Conversation f
 Conversation width: drag the divider on its left edge to resize between 280 and 480 pixels. Focus the divider and use Left/Right for 20-pixel steps or Home/End for the limits. The width survives collapsing/reopening the pane within the page; reloading uses the layout default. This replaces the hard-to-discover native corner resize grip. The browser regression covers pointer dragging, keyboard limits, code-pane space, and collapse/reopen.
 
 Selection actions now appear in a bordered floating toolbar beside the visible selected lines, with Ask emphasized. The toolbar stays within the code viewport, leaves line numbers available for Shift-click extension, and hides when the selection scrolls out of view. Clear selection removes it. The long-diff browser regression checks proximity, viewport bounds, attachment, scrolling away/back, and clearing; existing range/highlight tests remain required.
+
+PR #11 review round 1 reproduced a stale-poll race: a held question-list response hid a question submitted after the poll began. Review actions and refreshes now advance a generation counter; earlier poll successes and errors are ignored. The browser regression failed with one visible note instead of two before the fix.

test/browser/review.spec.ts

@@ -212,3 +212,14 @@ test('Clear selection removes native text selection as well as selected lines',a
  await page.locator('#code').press('ArrowRight');
  await expect(page.getByRole('group',{name:'Selected code'})).toBeHidden();
 });
+test('ignores question polls started before a newer submission',async({page})=>{
+ const config=app.service.config;await app.close();app=await startServer(config,0,()=>new Promise(()=>{}));
+ await page.goto(app.url);await page.getByLabel('Question about this item').fill('First question');await page.getByRole('button',{name:'Ask agent',exact:true}).click();await expect(page.getByText('Agent · Answering…',{exact:true})).toBeVisible();
+ let release!:()=>void,arrived!:()=>void;const held=new Promise<void>(r=>release=r),captured=new Promise<void>(r=>arrived=r);
+ await page.route('**/api/questions',async route=>{const response=await route.fetch();arrived();await held;await route.fulfill({response});});
+ await captured;
+ await page.getByLabel('Question about this item').fill('Second question');await page.getByRole('button',{name:'Ask agent',exact:true}).click();await expect(page.locator('#notes .note')).toHaveCount(2);
+ release();await page.waitForResponse(response=>response.url().endsWith('/api/questions'));
+ await page.waitForTimeout(100);
+ expect(await page.locator('#notes .note').count()).toBe(2);
+});

web/public/app.js

@@ -19,6 +19,7 @@ let data,
   mode = "question",
   since = false,
   busy = false;
+let reviewGeneration = 0;
 const drafts = new Map();
 const attachments = new Map();
 let snippetSelection = null;
@@ -75,6 +76,7 @@ function showFailure(message) {
 async function refresh() {
   if (busy) return;
   busy = true;
+  reviewGeneration++;
   renderAttachment();
   $("banner").textContent = "Linking changes to plan items…";
   try {
@@ -96,6 +98,7 @@ async function refresh() {
 async function act(command) {
   if (busy || !data) return false;
   busy = true;
+  reviewGeneration++;
   renderAttachment();
   try {
     rememberDraft();
@@ -597,8 +600,9 @@ setInterval(async()=>{
     renderNotes({ follow: true });return;
   }
   pollingQuestions=true;
-  try {const response=await api("/api/questions");if(data){data.notes=response.notes;renderNotes({ follow: true });}}
-  catch { $("saved").textContent="Could not refresh agent answers. Use Refresh to reconnect."; }
+  const generation = reviewGeneration;
+  try {const response=await api("/api/questions");if(data && generation === reviewGeneration){data.notes=response.notes;renderNotes({ follow: true });}}
+  catch { if (generation === reviewGeneration) $("saved").textContent="Could not refresh agent answers. Use Refresh to reconnect."; }
   finally {pollingQuestions=false;}
 },2000);
 $("settings").onclick=async()=>{