Read the trusted plan context with main's hardened Git invocation

main (#82, #83) replaced isolatedGitEnvironment with HARDENED_GIT_OPTIONS
and hardenedGitEnvironment. planContext() now uses both. That also adds
--no-replace-objects: before, a replace ref for the snapshot's base made
ls-tree list the replacement's tree as the trusted base entries. A test
replaces the base with the head commit and fails on the old invocation.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: mchwang

runner/review.ts

@@ -5,7 +5,7 @@ import { Store, type ReviewState, type SnippetReference } from './store.ts';
 import type { PlanIdentity } from '../core/identity.ts';
 import { readHistory } from '../git/history.ts';
 import { execFileSync } from 'node:child_process';
-import { isolatedGitEnvironment } from '../scripts/git-environment.ts';
+import { HARDENED_GIT_OPTIONS, hardenedGitEnvironment } from '../scripts/git-environment.ts';
 import type { BaseEntry, PlanContext } from '../core/plan.ts';
 import { linkHistory } from '../core/linking.ts';
 import { applyChoices, approvalStates, approveItem, choiceKeys, fingerprint, reviewedSegment, stable } from '../core/approvals.ts';
@@ -122,11 +122,13 @@ export class ReviewService {
       const normalized = pathIdentity.unicodeNormalization === 'NFC' ? path.normalize('NFC') : path;
       return pathIdentity.caseSensitive ? normalized : normalized.toLowerCase();
     };
-    const listing = execFileSync('git', ['-c', 'core.hooksPath=/dev/null', 'ls-tree', '-rz', snapshot.base], { cwd: repository, env: isolatedGitEnvironment(), encoding: 'utf8', maxBuffer: 64 * 1024 * 1024 });
+    // Hardened like every repository Git call (#82, #83): no replace objects, hooks, network or inherited environment.
+    const git = (args: string[], maxBuffer?: number) => execFileSync('git', [...HARDENED_GIT_OPTIONS, ...args], { cwd: repository, env: hardenedGitEnvironment(), encoding: 'utf8', maxBuffer, stdio: ['ignore', 'pipe', 'pipe'] });
+    const listing = git(['ls-tree', '-rz', snapshot.base], 64 * 1024 * 1024);
     const baseEntries: BaseEntry[] = listing.split('\0').filter(Boolean).map(record => {
       const split = record.indexOf('\t'), [mode, , oid] = record.slice(0, split).split(' '), path = record.slice(split + 1);
       if (mode === '160000') return { path, kind: 'gitlink' };
-      if (mode === '120000') return { path, kind: 'symlink', target: execFileSync('git', ['cat-file', 'blob', oid!], { cwd: repository, env: isolatedGitEnvironment(), encoding: 'utf8' }) };
+      if (mode === '120000') return { path, kind: 'symlink', target: git(['cat-file', 'blob', oid!]) };
       return { path, kind: 'file' };
     });
     return { identity, issue: plan.issue, baseEntries, pathKey, allowedCommands: [] };

test/runner-planning-feedback.test.ts

@@ -9,6 +9,8 @@ import { afterEach, describe, expect, it, vi } from 'vitest';
 import { createDemo } from '../scripts/demo.ts';
 import { startServer, type PlanningDeps } from '../web/server.ts';
 import { Store } from '../runner/store.ts';
+import { ReviewService } from '../runner/review.ts';
+import { fixtureGit } from './fixtures/git.ts';
 import type { AuthorProvider } from '../core/planning-author.ts';
 import type { EditReply } from '../core/plan.ts';
 
@@ -95,6 +97,22 @@ describe('feedback from review actions', () => {
   });
 });
 
+describe('trusted plan context', () => {
+  it('reads the base tree itself, not a replacement object for it', () => {
+    const root = mkdtempSync(join(tmpdir(), 'codeboost-f1e-')); roots.push(root);
+    const config = createDemo(join(root, 'demo')), service = new ReviewService(config);
+    try {
+      const snapshot = service.store.getSnapshot(config.identity);
+      const paths = () => service.planContext().baseEntries.map(entry => entry.path).sort();
+      const expected = paths();
+      expect(expected).not.toContain('debug.log');
+      // A replace ref makes plain Git read the head commit (which adds debug.log) wherever the base is named.
+      fixtureGit(config.repository, 'replace', snapshot.base, snapshot.head);
+      expect(paths()).toEqual(expected);
+    } finally { service.close(); }
+  });
+});
+
 describe('planning API for lane G', () => {
   const reply = (revision: number): EditReply => ({ schema_version: 1, base_revision: revision, reply: 'Suggestion', edits: [{ op: 'set_field',
     item: 'P1', summary: 'Rename', reason: 'Clearer', field: 'title', value: 'Clearer title', file: null, check: null, check_index: null, depends_on: null, new_item: null }] });