Track answer assignment context

Author: mchwang

docs/implementation/read-only-review.md

@@ -103,8 +103,10 @@ PR #11 round 8 returned no inline findings and identified one related summary ga
 
 PR #11 round 9 returned no inline findings and identified shutdown ordering in its summary. Server shutdown now stops accepting connections and drains in-flight HTTP requests before closing the question manager and database. A partial-body request regression proves a question already admitted during shutdown starts its agent and is persisted as interrupted rather than left unanswered.
 
-Current PR validation: 187 unit/integration tests, 32 browser tests, typecheck, and diff checks. Earlier counts above identify the stage when each behavior was added.
+Current PR validation: 188 unit/integration tests, 32 browser tests, typecheck, and diff checks. Earlier counts above identify the stage when each behavior was added.
 
 The documentation-only review after adding `AGENTS.md` exposed one more concrete lifecycle race: an expired persisted attempt could show Retry while its cancelled provider was still settling. Question polling now exposes whether the local invocation remains active, displays Finishing cancellation, and keeps polling without exposing Retry until settlement. A browser regression advances the persisted clock while leaving the invocation unresolved, then confirms Retry appears only after settlement.
 
 The follow-up review exposed the same active-job marker missing from the initial review response. Reloading during provider settlement could therefore expose Retry and stop polling. Initial loads and action responses now include the marker used by question polling; the browser regression reloads during settlement and confirms Retry remains hidden until the invocation finishes.
+
+The next review made assignment drift concrete for item-level answers without snippet references. Each answer now records a hash of the changed segments supplied for its item. Moving code into or out of that item preserves the answer but labels it as earlier review context; a regression assigns new code without changing the snapshot or plan revision and checks the historical marker.

runner/questions.ts

@@ -32,7 +32,7 @@ export class Questions {
     const provider=this.service.store.questionProvider();
     const agent=this.agent ?? (provider ? cliQuestionAgent(provider) : undefined);
     const attempt=randomUUID(), controller=new AbortController();
-    this.service.store.beginAnswer(this.service.config.identity,id,attempt,provider??undefined);
+    this.service.store.beginAnswer(this.service.config.identity,id,attempt,provider??undefined,note.contextId);
     if(this.running.size>=2){this.service.store.finishAnswer(this.service.config.identity,id,attempt,{status:'failed',error:'Two questions are already running. Retry when one finishes.'});return;}
     const timeout=setTimeout(()=>controller.abort(new Error('Agent timed out. Try again.')),120_000);
     let invocation: Promise<string> | undefined;

runner/review.ts

@@ -52,7 +52,8 @@ export class ReviewService {
       if (states[item.id] === 'approved' && (segments.some(segment => segment.row === 'Ambiguous' && segment.owners.includes(item.id)) || item.depends_on.some(id => states[id] === 'stale'))) states[item.id] = 'stale';
     }
     const expected: ReviewState = { revision: plan.revision, snapshotId: snapshot.id, reviewVersion };
-    const notes = this.store.getReviewNotes(identity).map(note => ({ ...note, answerOutdated: note.snapshotId!==snapshot.id || note.revision!==plan.revision, outdated: !!note.reference && (note.reference.head !== history.head || note.reference.base !== history.base || !segments.some(segment => segment.key === note.reference!.key && segment.row === note.item)) }));
+    const contextIds = new Map(plan.items.map(item => [item.id,createHash('sha256').update(JSON.stringify(segments.filter(segment=>segment.row===item.id).map(segment=>segment.key))).digest('hex')]));
+    const notes = this.store.getReviewNotes(identity).map(note => {const contextId=contextIds.get(note.item)!;return { ...note, contextId, answerOutdated: note.snapshotId!==snapshot.id || note.revision!==plan.revision || (!!note.answer?.contextId && note.answer.contextId!==contextId), outdated: !!note.reference && (note.reference.head !== history.head || note.reference.base !== history.base || !segments.some(segment => segment.key === note.reference!.key && segment.row === note.item)) };});
     if (this.store.reviewVersion(identity) !== reviewVersion || this.store.getPlan(identity).revision !== plan.revision || this.store.getSnapshot(identity).id !== snapshot.id) throw new Error('Stale review state. Reload before writing.');
     const items = plan.items.map(item => {
       const owned = segments.filter(segment => segment.row === item.id);

runner/store.ts

@@ -13,7 +13,7 @@ export function requireSupportedNode(version = process.versions.node): void {
 export interface Snapshot { id: string; base: string; head: string }
 export interface ReviewState { revision: number; snapshotId: string; reviewVersion?: number }
 export interface SnippetReference { key: string; path: string; side: 'old' | 'new'; start: number; end: number; text: string; head: string; base: string }
-export interface QuestionAnswer { provider?: 'claude' | 'codex'; attempt: string; status: 'pending' | 'complete' | 'failed'; expiresAt: number; text?: string; error?: string }
+export interface QuestionAnswer { provider?: 'claude' | 'codex'; attempt: string; contextId?: string; status: 'pending' | 'complete' | 'failed'; expiresAt: number; text?: string; error?: string }
 export interface ReviewNote { id: string; item: string; kind: 'question' | 'change'; text: string; reference?: SnippetReference; answer?: QuestionAnswer; createdAt: string; revision: number; snapshotId: string }
 export interface LedgerEntry { sha: string; owner: string | null; origin: 'owned' | 'foreign'; sourceSha: string | null }
 export interface Checkpoint {
@@ -268,15 +268,15 @@ export class Store {
       return note;
     });
   }
-  beginAnswer(identity: PlanIdentity, id: string, attempt: string, provider?: 'claude' | 'codex'): void {
+  beginAnswer(identity: PlanIdentity, id: string, attempt: string, provider?: 'claude' | 'codex', contextId?: string): void {
     const key=identityKey(identity);
     this.#transaction(()=>{
       const row=this.#get('SELECT data FROM review_notes WHERE key=? AND id=?',key,id);
       if(!row) throw new Error('Question not found.');
       const note=decode<ReviewNote>(row.data);
       if(note.kind!=='question' || note.answer?.status==='complete') throw new Error('Question already answered.');
       if(note.answer?.status==='pending' && note.answer.expiresAt>Date.now()) throw new Error('Agent is already answering this question.');
-      note.answer={attempt,status:'pending',expiresAt:Date.now()+125000,...(provider?{provider}:{})};
+      note.answer={attempt,status:'pending',expiresAt:Date.now()+125000,...(provider?{provider}:{}),...(contextId?{contextId}:{})};
       this.#run('UPDATE review_notes SET data=? WHERE key=? AND id=?',encode(note),key,id);
     });
   }

test/questions.test.ts

@@ -95,3 +95,13 @@ it('rejects questions whose snippet was reassigned without changing the snapshot
  const agent=vi.fn(async()=>'Should not run');const manager=new Questions(service,agent);managers.push(manager);
  expect(()=>manager.start(note.id,moved)).toThrow(/older review|outdated/);expect(agent).not.toHaveBeenCalled();
 });
+it('marks an item-level answer historical when assigned code changes',async()=>{
+ const service=fixture(),initial=service.load(),foreign=initial.segments.find(s=>s.row==='Unplanned')!;
+ const asked=service.act({action:'note',item:'P1',kind:'question',text:'Is this item complete?',token:initial.token});
+ const manager=new Questions(service,async()=>'It is complete for the supplied changes.');managers.push(manager);
+ manager.start(asked.createdNoteId!,asked);await vi.waitFor(()=>expect(service.store.getReviewNotes(service.config.identity)[0]?.answer?.status).toBe('complete'));
+ const index=initial.segments.findIndex(segment=>segment.key===foreign.key);
+ service.store.saveReview(service.config.identity,asked.expected,[],[{action:'assign',item:'P1',key:choiceKeys(initial.segments,service.config.identity)[index]!}]);
+ const changed=service.load(),note=changed.notes.find(note=>note.id===asked.createdNoteId)!;
+ expect(changed.snapshot.id).toBe(asked.snapshot.id);expect(note.answer?.text).toContain('complete');expect(note.answerOutdated).toBe(true);
+});