Replace stale question retries with current-review guidance

Author: mchwang

docs/implementation/read-only-review.md

@@ -84,3 +84,5 @@ Conversation width: drag the divider on its left edge to resize between 280 and
 Selection actions now appear in a bordered floating toolbar beside the visible selected lines, with Ask emphasized. The toolbar stays within the code viewport, leaves line numbers available for Shift-click extension, and hides when the selection scrolls out of view. Clear selection removes it. The long-diff browser regression checks proximity, viewport bounds, attachment, scrolling away/back, and clearing; existing range/highlight tests remain required.
 
 PR #11 review round 1 reproduced a stale-poll race: a held question-list response hid a question submitted after the poll began. Review actions and refreshes now advance a generation counter; earlier poll successes and errors are ignored. The browser regression failed with one visible note instead of two before the fix.
+
+PR #11 review round 2 confirmed the poll fix and raised an outdated-retry issue in its summary. A browser regression reproduced the retry button on an older snapshot; such unanswered questions now instruct the reviewer to ask again against current code. Completed historical answers retain their outdated label. The summary's timeout-reporting concern supplied no concrete failure; timeout and interrupted-lease regressions remain in the validation suite.

test/browser/review.spec.ts

@@ -223,3 +223,13 @@ test('ignores question polls started before a newer submission',async({page})=>{
  await page.waitForTimeout(100);
  expect(await page.locator('#notes .note').count()).toBe(2);
 });
+test('outdated questions explain how to continue without offering a broken retry',async({page})=>{
+ const service=app.service;
+ service.act({action:'note',item:'P1',kind:'question',text:'Old question',token:service.load().token});
+ execFileSync('git',['-c','core.hooksPath=/dev/null','commit','--allow-empty','-m','New snapshot'],{cwd:service.config.repository,stdio:'pipe'});
+ await page.goto(app.url);
+ await expect(page.getByText('Old question',{exact:true})).toBeVisible();
+ await expect(page.getByRole('button',{name:'Retry answer',exact:true})).toHaveCount(0);
+ await expect(page.getByText('This question refers to an earlier review. Ask again against the current code.',{exact:true})).toBeVisible();
+ await expect(page.getByRole('heading',{name:'Bound exponential retries'})).toBeVisible();
+});

web/public/app.js

@@ -558,6 +558,7 @@ function answerMarkup(note) {
   if(note.kind!=="question") return "";
   const answer=note.answer;
   if(answer?.status==="complete") return `<section class="agent-answer"><strong>${answer.provider === "claude" ? "Claude Code" : answer.provider === "codex" ? "Codex" : "Agent"}</strong><p>${esc(answer.text)}</p>${note.answerOutdated ? '<small>! Answer refers to an earlier review snapshot.</small>' : ""}</section>`;
+  if(note.answerOutdated) return '<p class="warn">This question refers to an earlier review. Ask again against the current code.</p>';
   if(answer?.status==="pending" && answer.expiresAt>Date.now()) return '<p role="status">Agent · Answering…</p>';
   const error=answer?.status==="failed"?answer.error:answer?.status==="pending"?"Agent was interrupted or timed out.":"Answer not started. Choose an agent in Settings or retry when capacity is available.";
   return `<p class="warn">! ${esc(error)}</p><button data-retry-question="${esc(note.id)}">Retry answer</button>`;