Reject all Unicode control characters in v1 paths and commands

Author: mchwang

core/plan.ts

@@ -72,14 +72,14 @@ export function assertEditReply(value: unknown): asserts value is EditReply {
 }
 /** Canonical paths make duplicate checks reliable and exclude Git metadata. */
 export function isRepoPath(path: string): boolean {
-  return path.length > 0 && !/[\\:\x00-\x1f\x7f]/u.test(path) &&
+  return path.length > 0 && !/[\\:\p{Cc}]/u.test(path) &&
     path.split('/').every(part => part !== '' && part !== '.' && part !== '..' &&
       part.toLowerCase() !== '.git');
 }
 
 /** Small literal-argv grammar, deliberately not a shell parser. Never executes. */
 export function commandArgv(command: string): string[] {
-  if (/[\\\x00-\x1f\x7f]/u.test(command))
+  if (/[\\\p{Cc}]/u.test(command))
     fail('command-syntax', 'Commands must contain literal arguments, not shell syntax.');
   const argv: string[] = [];
   let word = '', quote = '', started = false;
@@ -109,7 +109,7 @@ function parents(path: string): string[] {
   const parts = path.split('/'); return parts.slice(0, -1).map((_, i) => parts.slice(0, i + 1).join('/'));
 }
 function linkTarget(path: string, target: string, key: (path: string) => string, entries: ReadonlyMap<string, BaseEntry>): string | null {
-  if (!target || target.startsWith('/') || /[\\:\x00-\x1f\x7f]/u.test(target)) return null;
+  if (!target || target.startsWith('/') || /[\\:\p{Cc}]/u.test(target)) return null;
   const parts = path.split('/').slice(0, -1);
   for (const component of target.split('/')) {
     if (component === '' || component === '.') continue;

test/plan-v1.test.ts

@@ -89,3 +89,9 @@ it('rejects directories, colliding base leaves, and retained links through hidde
  p.items[0]!.files[0] = { path: 'b', kind: 'rename', renamed_from: 'a', change: 'Move' };
  expect(validatePlan(p, { ...context, baseEntries: [{ path: 'a', kind: 'symlink', target: 'other/../target' }, { path: 'other', kind: 'symlink', target: 'dir' }] }).errors.some(e => e.code === 'symlink-target')).toBe(true);
 });
+
+it('rejects C1 control characters in commands and paths', () => {
+ expect(() => commandArgv("test '\u0085'")).toThrow();
+ const p = plan(); p.items[0]!.files[0]!.path = 'a\u0085';
+ expect(validatePlan(p, { ...context, baseEntries: [{ path: 'a\u0085', kind: 'file' }] }).errors.length).toBeGreaterThan(0);
+});