Refresh only an opened PR: drop beginRefresh's unused adopt path

Adoption of an abandoned opening's PR happens in adoptOpening, under
the state-version guard, when publish first sees the PR. beginRefresh
now requires an opened row, leaving one adoption path.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: mchwang

runner/store.ts

@@ -991,16 +991,13 @@ export class Store {
    * draft change may land even if their confirmation is lost; the record keeps that visible until the update is
    * confirmed or abandoned. Returns the state version the update owns.
    */
-  beginRefresh(identity: PlanIdentity, input: { checkId: string; openingId: string; headSha: string; draft: boolean; adopt?: { number: number; url: string } }): number {
+  beginRefresh(identity: PlanIdentity, input: { checkId: string; openingId: string; headSha: string; draft: boolean }): number {
     const key = identityKey(identity);
     return this.#transaction(() => {
       this.#assertCheckedHead(identity, input);
+      // Only an opened PR is refreshed; an abandoned opening's PR is adopted first, by adoptOpening, when publish sees it.
       const row = this.#get('SELECT state FROM task_pull_requests WHERE plan_key=? AND opening_id=?', key, input.openingId);
-      // An abandoned opening whose PR became visible later is adopted here, under the same guard as the update.
-      if (row?.state === 'abandoned' && input.adopt) {
-        if (!Number.isSafeInteger(input.adopt.number) || input.adopt.number < 1 || typeof input.adopt.url !== 'string') throw new Error('Invalid pull request.');
-        this.#run("UPDATE task_pull_requests SET state='opened', number=?, url=? WHERE opening_id=?", input.adopt.number, input.adopt.url, input.openingId);
-      } else if (row?.state !== 'opened') throw new GuardRefusal('Unknown pull request.');
+      if (row?.state !== 'opened') throw new GuardRefusal('Unknown pull request.');
       this.#touch(key);
       const version = this.#task(key).state_version as number;
       this.#run('UPDATE task_pull_requests SET refresh_head=?, refresh_draft=?, refresh_version=?, updated_at=? WHERE opening_id=?',

test/publish.test.ts

@@ -263,6 +263,14 @@ describe('PR records', () => {
     expect(await publisher.publish(identity)).toMatchObject({ kind: 'opened', number: 9, status: 'cancelled' });
     expect(store.taskPullRequests(identity)).toMatchObject([{ state: 'opened', number: 9 }]);
   });
+  it('refreshes only an opened PR: an abandoned opening must be adopted first', async () => {
+    const store = runningTask();
+    const clear = () => store.recordAlreadyFixed(identity, store.getTask(identity).stateVersion, { snapshotId: store.getSnapshot(identity).id, draft: false, result: { outcome: 'clear', baseHead: oid(9) } });
+    const opening = store.beginPullRequest(identity, { checkId: clear().id, repository: 'owner/repo', base: 'main', headBranch: 'b', headSha: oid(2), draft: false });
+    store.abandonPullRequestOpening(identity, opening.openingId);
+    expect(() => store.beginRefresh(identity, { checkId: clear().id, openingId: opening.openingId, headSha: oid(2), draft: false })).toThrow(/Unknown pull request/);
+    expect(store.taskPullRequests(identity)).toMatchObject([{ state: 'abandoned', number: null, refresh: null }]);
+  });
   it('binds an opening to the checked head, with no task change since the check', async () => {
     const store = runningTask();
     const check = store.recordAlreadyFixed(identity, store.getTask(identity).stateVersion, { snapshotId: store.getSnapshot(identity).id, draft: false, result: { outcome: 'clear', baseHead: oid(9) } });