Skip to content

Commit b11b93f

Browse files
authored
Record selection accessibility review lesson (#15)
* Record selection accessibility review lesson * Make review lesson capture a merge gate
1 parent 0cadca8 commit b11b93f

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

‎AGENTS.md‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ For features with background jobs, polling, retries, cancellation, or shutdown:
2222
- Clear a submitted draft only if its current value and attachment still match what was submitted. Treat this as compare-and-swap behavior.
2323
- Preserve completed historical results, but visibly mark them stale when their snapshot, plan revision, assignment, or referenced code no longer matches.
2424
- When polling updates one part of the screen, update only that state. Preserve scroll position unless the user was already following the bottom.
25+
- When a row or control's visual selection determines the current content or input, expose the same state with the appropriate accessibility attribute, such as `aria-current` or `aria-selected`, and test it across navigation.
2526

2627
## Required race regressions
2728

@@ -45,4 +46,4 @@ Every reproduced race requires a failing-before and passing-after regression. As
4546
- Before requesting automated review, report the current head, CI state, mergeability, unresolved threads, and deferred follow-up issues.
4647
- Reproduce summary-only review concerns or turn them into a concrete follow-up issue. Do not repeatedly patch vague wording without a failure case.
4748
- For each review round, record what changed, what was declined and why, and the regression evidence. Re-request review until a round returns no new findings.
48-
- Before closing or merging a PR, extract the highest-value, broadly reusable lessons from its review and add concise rules to this file. Omit one-off implementation details and rules already covered here.
49+
- Treat review-lesson extraction as a merge gate. Before invoking merge, classify every review finding in the PR body as: covered by an existing rule (cite it), captured by a new rule in this branch (cite it), or one-off (record why). Do not merge until this audit is complete and every required `AGENTS.md` update is included in the reviewed head. Omit rules that merely repeat existing guidance.

0 commit comments

Comments
 (0)