Fix broken benchmark build - #98
Merged
Merged
Conversation
It doesn't take that much, and avoid linking problems when the library was compiled, for example, with a different C++ standard library.
Avoids the ninja problem where multiple checks where creating the same
module in the same folder:
ninja: build stopped: multiple rules generate src/utils.mod.
daniel-otero
requested review from
alvrogd,
d-alonso and
inaki-amatria
and removed request for
d-alonso and
inaki-amatria
August 21, 2025 07:17
daniel-otero
temporarily deployed
to
github-pages
August 21, 2025 07:51 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Comment on lines
+50
to
+54
| # Setup separated dirs to avoid output files clashing between checks | ||
| set_target_properties(${CHECKID} PROPERTIES | ||
| Fortran_MODULE_DIRECTORY "${CHECKID}" | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
How come this workflow didn't catch this error earlier?? Is GNU Make silently ignoring the conflict? 😨
Contributor
Author
There was a problem hiding this comment.
On my computer (without the fix) the Unix Makefiles generation "just works", but all the Fortran modules are in build/src, so I guess they get overwritten in the build.
Nice catch by ninja, I guess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to run the benchmarks I've found a ninja error that didn't let me compile:
After fixing it, linking against my system google benchmark version raised this link error:
The rest are minor changes.