Skip to content

chore: test safe-chain in Docker - #6313

Draft
robdiciuccio wants to merge 1 commit into
mainfrom
rs/safe-chain
Draft

chore: test safe-chain in Docker#6313
robdiciuccio wants to merge 1 commit into
mainfrom
rs/safe-chain

Conversation

@robdiciuccio

Copy link
Copy Markdown
Contributor

Link to Jira issue

Is PM acceptance required?

  • Yes - don't merge until Jira issue is accepted!
  • No - merge after code review approval

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Explain the implementation goals being solved or the feature with the reviewer in mind
  • Mention any relevant issues or insights to be shared with the reviewer.
  • Alternatives considered

How to test?

  • Describe the testing approach taken to verify the changes, including:
    • Unit/integration/manual tests
    • Test data used
  • Specify any relevant testing environments used (e.g., development, staging, demo, Heroku).
  • Risk Assessment
    • Risks or side effects associated with the changes and how they were mitigated.
    • Highlight areas that may need extra attention during code review or testing.
    • Paste SQL queries or output where relevant

Screenshots (visual changes)

  • Before

  • After

@github-actions

Copy link
Copy Markdown

Heroku app: https://gyr-review-app-6313-924c7e035c5a.herokuapp.com/
View logs: heroku logs --app gyr-review-app-6313 (optionally add --tail)

@embarnard

Copy link
Copy Markdown
Contributor

@robdiciuccio same with this, should we ignore since its a draft?

@robdiciuccio

Copy link
Copy Markdown
Contributor Author

@embarnard yes, ok to ignore drafts from me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants