Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions app/views/public_pages/home.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -70,17 +70,17 @@
</div>
</div>

<div class="slab slab-habla-espanol">
<div class="grid">
<div class="rounded-box">
<h2 class="title spacing-below-5">¿habla español?</h2>
<p>Tenemos opciones para ti! Declarar en español, obtener tu máximo reembolso.</p>
<% unless locale == :es %>
<span><%= link_to_locale('es', 'Traducir esta página al español', { "data-track-click": "intake-language-changed-habla-espanol-section" }) %></span>
<% end %>
<% unless locale == :es %>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this +1

<div class="slab slab-habla-espanol">
<div class="grid">
<div class="rounded-box">
<h2 class="title spacing-below-5">¿habla español?</h2>
<p>Tenemos opciones para ti! Declarar en español, obtener tu máximo reembolso.</p>
<span><%= link_to_locale('es', 'Traducir esta página al español', { "data-track-click": "intake-language-changed-habla-espanol-section" }) %></span>
</div>
</div>
</div>
</div>
<% end %>

<%= render "shared/service_comparison" %>

Expand Down
13 changes: 0 additions & 13 deletions app/views/shared/_footer.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -43,19 +43,6 @@
<% end %>
</li>

<li>
<%= link_to new_user_session_path do %>
<%= t("views.shared.footer.volunteer_sign_in") %>
<% end %>
</li>


<li>
<%= link_to "https://www.getyourrefundstatus.org/" do %>
<%= t("views.shared.footer.service_status") %>
<% end %>
</li>

<% unless Rails.env.production? %>
<li><%= link_to "Flow explorer", flows_path %></li>
<li><%= link_to "Session toggles", session_toggles_path, target: "_blank" %></li>
Expand Down
5 changes: 1 addition & 4 deletions app/views/shared/_header.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,7 @@
<%= f.submit value: t("general.sign_out"), class: "button--link" %>
<% end %>
<% else %>
<%= link_to t("general.login"), new_portal_client_login_path, class: "toolbar__item text--small text--bold" %>
<% if !@in_intake_flow && @get_started_link.present? %>
<%= link_to t("general.get_started"), @get_started_link, class: "toolbar__item button button--toolbar button--small is-mobile-hidden--inline" %>
<% end %>
<%= link_to t("general.sign_in"), new_portal_client_login_path, class: "toolbar__item button button--toolbar button--small is-mobile-hidden--inline" %>
<% end %>
</div>
<% end %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/shared/_in_person_vita_card.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<% if show_get_started %>
<div class="button-wrapper">
<div>
<%= link_to t("general.get_started"), vita_providers_path, "data-track-click": "service-comparison-in-person-vita-providers", class: "button text--centered button--wide" %>
<%= link_to t("views.shared.in_person_vita_card.link_button"), vita_providers_path, "data-track-click": "service-comparison-in-person-vita-providers", class: "button text--centered button--wide" %>
</div>
</div>
<% end %>
Expand Down
12 changes: 6 additions & 6 deletions config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6129,16 +6129,15 @@ en:
reveal_body_4: 'Other features:'
reveal_title: Additional information
subtitle: File on your own and get help when you need it
title: File Myself
title: FileMyself
document_deadline_warning:
body_html: The tax filing deadline for all 2025 returns is %{tax_deadline}. Use the <a href='https://www.getyourrefund.org/en/diy/qualifications' target='_blank' rel='noopener noreferrer'>tool File Myself</a> to file on your own before the deadline. If you don't owe, you can submit your taxes after that date without penalty. <a href='https://intercom.help/getyourrefundorg/en/articles/11048561-filing-an-extension' target='_blank' rel='noopener noreferrer'>Learn more in our FAQ.</a>
environment_warning:
banner: This site is for example purposes only. If you want help with your taxes, go to
off_season_filing: We are unable to accept new clients after %{end_of_intake_date}. If your return is in progress, log in and submit your documents by %{end_of_docs_date} in order to file by the deadline.
footer:
service_description_html: GetYourRefund.org is a non-profit service built by %{cfa_link} in partnership with IRS-certified Volunteer Income Tax Assistance (%{vita_link}) sites nationally.
service_description_html: GetYourRefund.org is a non-profit service built by %{cfa_link}
service_status: Service status
volunteer_sign_in: Volunteer sign in
grayscale_partner_logo:
provider_homepage: "%{provider_name} Homepage"
in_person_vita_card:
Expand All @@ -6147,6 +6146,7 @@ en:
bullet_3: Varies by location
bullet_4: Available in-person
bullet_5_html: "<b>Physical copies</b> of Social Security or Individual Taxpayer Identification Number Card required"
link_button: Find a Location
reveal_b1: All states
reveal_b2: Non-residents [varies by location]
reveal_b3: Puerto Rico residents [varies by location]
Expand All @@ -6158,8 +6158,8 @@ en:
reveal_body_3: 'Available to residents of:'
reveal_body_4: 'Other features:'
reveal_title: Additional Information
subtitle: Answer a few questions and let a tax expert file for you
title: In-person VITA
subtitle: Find a local IRS site and file with help
title: Assist (In-person)
progress_bar:
progress_text: 'Intake progress:'
service_comparison:
Expand Down Expand Up @@ -6209,4 +6209,4 @@ en:
reveal_body_4: 'Other features:'
reveal_title: Additional Information
subtitle: Answer a few questions and let a tax expert file for you
title: File with Help
title: Assist (Virtual)
20 changes: 10 additions & 10 deletions config/locales/es.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6158,25 +6158,25 @@ es:
reveal_body_3: 'Disponible para residentes de:'
reveal_body_4: 'Otras características:'
reveal_title: Información adicional
subtitle: Responda unas preguntas y deje que un experto en impuestos presente su declaración
title: Declarar por mi cuenta
subtitle: Prepara tus propias declaraciones de impuestos y recibe ayuda si necesitas
title: FileMyself
document_deadline_warning:
body_html: La fecha límite para declarar sus impuestos de 2025 es el %{tax_deadline}. Use <a href='https://www.getyourrefund.org/es/diy/qualifications' target='_blank' rel='noopener noreferrer'>la herramienta File Myself</a> para declarar por su cuenta antes de la fecha límite. Si no debe impuestos, puede presentar su declaración después de esa fecha sin penalización. <a href='https://intercom.help/getyourrefundorg/es/articles/11048561-obtener-mas-tiempo-para-declarar' target='_blank' rel='noopener noreferrer'>Conozca más en nuestras preguntas frecuentes.</a>
environment_warning:
banner: Este sitio es sólo para pruebas. Si necesitas ayuda con tus impuestos, visita
off_season_filing: No podemos aceptar nuevos clientes después de %{end_of_intake_date}. Si su declaración está en progreso, inicie sesión y envíe sus documentos antes de %{end_of_docs_date} para presentarla antes de la fecha límite.
footer:
service_description_html: GetYourRefund.org es un servicio sin ánimo de lucro creado por %{cfa_link} en colaboración con los sitios de Asistencia Voluntaria al Contribuyente (%{vita_link}) certificados por el IRS en todo el país.
service_description_html: GetYourRefund.org es un servicio sin ánimo de lucro creado por %{cfa_link}.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The part that says: "sin ánimo de lucro " should say "sin fines de lucro". I believe its a bad translation. We should talk to the person that submitted it 😅

service_status: Estado del servicio
volunteer_sign_in: Sesión de voluntarios
grayscale_partner_logo:
provider_homepage: Portada de %{provider_name}
in_person_vita_card:
bullet_1: Apoyo personalizado
bullet_2: Declaraciones de impuestos estatales y federales
bullet_3: Varía según la ubicación
bullet_3: El tiempo varía según la ubicación
bullet_4: Disponible de manera presencial
bullet_5_html: Se requieren <b>copias físicas</b> de la tarjeta del Seguro Social o del Número de Identificación Personal del Contribuyente (ITIN)
bullet_5_html: "<b>Se requieren copias físicas</b> de la tarjeta del Seguro Social o Número de Identificación Personal del Contribuyente (ITIN)"
link_button: Buscar una ubicación
reveal_b1: Todos los estados
reveal_b2: No residentes (varía según la ubicación)
reveal_b3: Residentes de Puerto Rico (varía según la ubicación)
Expand All @@ -6188,8 +6188,8 @@ es:
reveal_body_3: 'Disponible para residentes de:'
reveal_body_4: 'Otras características:'
reveal_title: Información adicional
subtitle: Responda unas preguntas y deje que un experto en impuestos presente su declaración
title: VITA presencial
subtitle: Encuentra un sitio del IRS para recibir ayuda en persona declarando tus impuestos
title: Assist (In-person)
progress_bar:
progress_text: 'Progreso de la admisión:'
service_comparison:
Expand Down Expand Up @@ -6238,5 +6238,5 @@ es:
reveal_body_3: 'Disponible para residentes de:'
reveal_body_4: 'Otras características:'
reveal_title: Información adicional
subtitle: Responda algunas preguntas y deje que un profesional de impuestos presente su declaración a nombre suyo
title: Declarar con ayuda
subtitle: Responde unas preguntas y un experto en impuestos presenta tu declaración

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, it should say: "Contesta unas preguntas y un experto en impuestos presentará tu declaración"

responder and contestar both mean same "to answer", but Responder is more for actions and Contestar is more verbal, like: Answer the phone, a question, a message, etc

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll flag both of these to Ryan to see if we'd like to have updates here

title: Assist (Virtual)
11 changes: 6 additions & 5 deletions spec/features/visit_home_page_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,11 @@
allow(Rails.env).to receive(:production?).and_return(false)
end

scenario "it shows a sign in link" do
visit "/"
click_on "Volunteer sign in"
expect(page).to have_text "Sign in"
end
#commenting this out for now since Volunteer Sign In was removed from footer
#scenario "it shows a sign in link" do
# visit "/"
# click_on "Volunteer sign in"
# expect(page).to have_text "Sign in"
#end
end
end
2 changes: 1 addition & 1 deletion spec/features/web_intake/menu_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

visit "/"
within ".toolbar" do
expect(page).to have_css("a", text: "Login")
expect(page).to have_css("a", text: "Sign in")
end
end
end
Loading