GYR1-1166 Fix for extra query in ClientsController - #6425
Open
spompea-cfa wants to merge 5 commits into
Open
Conversation
|
Heroku app: https://gyr-review-app-6425-a656b92ca442.herokuapp.com/ |
spompea-cfa
changed the title
spompea-cfa
force-pushed
the
gyr1-1166-clientscontroller-query-fix-and-remove-archived-logic
branch
from
September 1, 2026 21:53
50eaa0b to
cf80d94
Compare
spompea-cfa
changed the title
spompea-cfa
marked this pull request as ready for review
September 1, 2026 22:14
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Jira issue
Is PM acceptance required?
What was done?
The initial issue was that logic in the HubClientPresenter#initialize would grab
an intake from
related_models_cache(so far so good) but subsequent logic(having to do with archived intakes) resulted in
client.intakebeing calledanyway (extra query) and the
related_models_cacheitem not being used.In ClientsController:
related_models_cacheis accessed (need tohave
.firstat the end)How to test?
I would suggest briefly smoke testing the Hub Clients page.