Skip to content

Responsive - #200

Open
MihajloVSc wants to merge 5 commits into
codeforcroatia:developfrom
MihajloVSc:main
Open

Responsive#200
MihajloVSc wants to merge 5 commits into
codeforcroatia:developfrom
MihajloVSc:main

Conversation

@MihajloVSc

Copy link
Copy Markdown

I recently added responsive features for the new header of the website. This update ensures that the header adapts seamlessly to different screen sizes, providing a better user experience on both mobile and desktop devices.

Additionally, I am planning a complete redesign of the website. To facilitate this process, I have also included other HTML files to support the new layout and functionality. This groundwork will help streamline the redesign and ensure a cohesive design throughout the site.

@schlos

schlos commented May 29, 2026

Copy link
Copy Markdown
Member

Code Review

🔴 Critical

  • No GitHub issue linked to this PR

✅ Issue Fix Verification

  • No issue referenced in PR body
  • Creates entirely new redesign/ directory alongside existing codebase
  • This appears to be a separate project/experiment, not a standard PR

📋 Code Quality Assessment

Files: 12 total including:

  • redesign/css/*.css (new CSS files)
  • redesign/index.html (new HTML)
  • web/cobrands/sass/_base.scss (removes font-weight from p)
Aspect Status Notes
Mixed changes ⚠️ Review Redesign folder + core CSS change don't align
Directory purpose ❓ Ask Is redesign/ meant to replace existing cobrands?
Global CSS change ⚠️ Caution Same p { font-weight } removal as PRs #201, #202

💡 Suggestions

  1. Clarify the relationship between redesign/ folder and existing web/cobrands/ - is this a full redesign or isolated components?
  2. Link to an issue for tracking
  3. Consider separating concerns (design files vs. core style changes)

✔️ Looks Good

  • N/A - requires clarification on intent

This was referenced May 29, 2026
@schlos

schlos commented May 31, 2026

Copy link
Copy Markdown
Member

This code change does not work for me:

image

@MihajloVSc could you please check again?

Also, I see you introduced new unnecessary files:
textfile.txt
testfile.txt

Could you make sure that PR's are clean without any test/dummy unnecessary files? We don't want those files ending in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants