Skip to content

New Issues - #201

Open
MihajloVSc wants to merge 7 commits into
codeforcroatia:developfrom
MihajloVSc:develop
Open

New Issues#201
MihajloVSc wants to merge 7 commits into
codeforcroatia:developfrom
MihajloVSc:develop

Conversation

@MihajloVSc

@MihajloVSc MihajloVSc commented Nov 14, 2024

Copy link
Copy Markdown

I added a text document with instructoons for new issue

@MihajloVSc MihajloVSc changed the title Nav New Issues Dec 5, 2024
@schlos

schlos commented May 29, 2026

Copy link
Copy Markdown
Member

Code Review

🔴 Critical

  • No GitHub issue linked to this PR

✅ Issue Fix Verification

📋 Code Quality Assessment

Changed File: web/cobrands/sass/_base.scss

Aspect Status Notes
CSS Syntax ✅ Valid No syntax errors detected
Global scope ⚠️ Caution Removing font-weight: normal from p affects all paragraphs site-wide
Duplicate PR ⚠️ Review Same change as PR #200 and #202

💡 Suggestions

  1. Link to an issue (e.g., "Closes Organize file and code structure of CSS #176" for CSS organization)
  2. If intentional, document why this reset is no longer needed
  3. Consider consolidating with PRs Responsive #200 and New issue branch #202

✔️ Looks Good

  • Minimal, focused change to single property

This was referenced May 29, 2026
@schlos

schlos commented May 31, 2026

Copy link
Copy Markdown
Member

@MihajloVSc thank you for your interest in contributing! I noticed this PR also contains text files (error.txt, responsive_error.txt, idea.txt) that describe issues rather than using GitHub Issues.

Please use the Issues tab to report bugs and feature requests:

  1. Click "New Issue"
  2. Describe the problem clearly — what you expected, what happened, and steps to reproduce
  3. Submit the issue for discussion

Pull requests should contain only code changes that fix a specific issue or add a feature. Each PR should reference an issue number (e.g., "Fixes #42").

I recommend closing these PRs and:

  1. Creating GitHub Issues for each bug you want to report
  2. If you want to fix something yourself, opening a new PR with only the relevant code changes
  3. Removing the text files — they are not part of the code change

See Creating an Issue for a guide on how to get started.

Let me know if you have any questions! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants