Skip to content

New issue branch - #202

Open
MihajloVSc wants to merge 8 commits into
codeforcroatia:developfrom
MihajloVSc:new-issue-branch
Open

New issue branch#202
MihajloVSc wants to merge 8 commits into
codeforcroatia:developfrom
MihajloVSc:new-issue-branch

Conversation

@MihajloVSc

Copy link
Copy Markdown

I have found several errors and issues in your GitHub project that need attention. There seems to be a lot to work on, but I noticed that these issues are not listed in the actual GitHub Issues section.

Despite this, I plan to go ahead and address them anyway, and I will continue making contributions to improve the project. If you'd like to review or track these changes later, please let me know how you prefer to handle them.

Thank you!

@schlos

schlos commented May 29, 2026

Copy link
Copy Markdown
Member

Code Review

🔴 Critical

  • No GitHub issue linked to this PR

✅ Issue Fix Verification

  • No issue referenced in PR body
  • Same change as PR New Issues #201: removes font-weight from p selector

📋 Code Quality Assessment

Changed File: web/cobrands/sass/_base.scss

Aspect Status Notes
CSS Syntax ✅ Valid No syntax errors detected
Global scope ⚠️ Caution Removing font-weight: normal affects all paragraphs
Duplicate PR ⚠️ Review Identical to PR #201 and similar to #200

💡 Suggestions

  1. Link to an issue (e.g., "Closes Organize file and code structure of CSS #176" for CSS organization)
  2. Consider consolidating duplicate PRs or explain the difference

✔️ Looks Good

  • Minimal, focused change to single property

This was referenced May 29, 2026
@schlos

schlos commented May 31, 2026

Copy link
Copy Markdown
Member

@MihajloVSc thank you for taking the time to contribute! I appreciate you wanting to help improve the project. However, this PR has some issues that need to be addressed before it can be merged.

The main problem: This pull request contains text files (error.txt, new_issue.txt, responsive_error.txt, idea.txt) that describe bugs and feature requests instead of using GitHub Issues. Please do not use pull request commits to report issues — text files submitted in PRs are not an effective way to track and discuss problems.

How to report bugs and feature requests properly:

  1. Go to the Issues tab
  2. Click "New Issue"
  3. Choose the appropriate bug report or feature request template (if available)
  4. Describe the issue clearly — what you expected to happen, what actually happened, and steps to reproduce
  5. Submit the issue

Project maintainers and other contributors can then discuss the issue, prioritize it, and volunteer to work on it.

How pull requests should work:

  • A pull request should contain only code changes that fix a specific issue or add a specific feature
  • Reference the issue number in the PR description (e.g., "Fixes popravitobase: Frontpage image cut when multiple address options are displayed #42")
  • Keep commits clean and focused — each commit should represent a single logical change
  • Do not include unrelated files, test artifacts, or issue descriptions as text files

What to do next:
Please close this PR and:

  1. Create a new GitHub Issue for each bug or feature you want to report
  2. If you want to fix an issue yourself, create a new PR that contains only the code changes needed to fix that specific issue
  3. Remove the text files (error.txt, new_issue.txt, responsive_error.txt, idea.txt) — they are not part of the code change

If you need help with the GitHub Issues workflow, see this guide.

Happy to help if you have any questions! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants