Repository navigation
fix(core): reject non-finite rate limit values - #581
ashutoshpalhare wants to merge 3 commits into
Conversation
anurag629
left a comment
There was a problem hiding this comment.
Thanks @ashutoshpalhare, the change is right. packages/core/src/limits/rate-limit.ts:59-60 now rejects NaN and Infinity for both limit and windowMs, as we settled in #452, and the new cases in packages/core/tests/limits/rate-limit.test.ts cover all four. The description is still the empty template, though, so two things before it can go in:
Closes #has no number, so the PR isn't linked to #452. Make itCloses #452, or the claim check fails.- "How I tested this" and "AI assistance" are empty. CONTRIBUTING.md asks for both: what you ran to check it, and either "none" or the tool and what you used it for. The description check fails while either one is empty.
Editing the description is enough, no new commit needed.
|
Hey @ashutoshpalhare, just checking in on this one. The code change is right, only the description is missing: |
What does this change?
Closes #
How I tested this
AI assistance
Checklist
devpnpm -r build,pnpm testandpnpm -r typecheckpass locallypnpm changeset) if this changescore,widgetorserverpnpm apirun andapi/committed if an exported type or option changed