Skip to content

fix(core): reject non-finite rate limit values #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ashutoshpalhare wants to merge 3 commits into from
Closed

fix(core): reject non-finite rate limit values #581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4270f5a
fix(core): reject non-finite rate limit values
ashutoshpalhare Nov 2, 2026
a065328
test(core): cover non-finite rate limit values
ashutoshpalhare Nov 2, 2026
46a8889
chore: add rate limiter validation changeset
ashutoshpalhare Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/finite-rate-limit-values.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@chatcops/core": patch
---

Reject non-finite rate limit values during limiter creation.
4 changes: 2 additions & 2 deletions packages/core/src/limits/rate-limit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ export function createRateLimiter(
rule: RateLimitRule,
options: RateLimiterOptions = {}
): { check(key: string): Promise<RateLimitResult> } {
if (rule.limit <= 0) throw new Error('limit must be greater than 0');
if (rule.windowMs <= 0) throw new Error('windowMs must be greater than 0');
if (!Number.isFinite(rule.limit) || rule.limit <= 0) throw new Error('limit must be a finite number greater than 0');
if (!Number.isFinite(rule.windowMs) || rule.windowMs <= 0) throw new Error('windowMs must be a finite number greater than 0');

const prefix = options.prefix ?? 'rl';
const now = options.now ?? Date.now;
Expand Down
12 changes: 8 additions & 4 deletions packages/core/tests/limits/rate-limit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,14 @@ function countersOf(options?: Parameters<typeof memoryStorage>[0]): CounterStore
describe('createRateLimiter', () => {
it('throws on invalid rule', () => {
const counters = countersOf();
expect(() => createRateLimiter(counters, { limit: 0, windowMs: 1000 })).toThrow('limit must be greater than 0');
expect(() => createRateLimiter(counters, { limit: -1, windowMs: 1000 })).toThrow('limit must be greater than 0');
expect(() => createRateLimiter(counters, { limit: 5, windowMs: 0 })).toThrow('windowMs must be greater than 0');
expect(() => createRateLimiter(counters, { limit: 5, windowMs: -1 })).toThrow('windowMs must be greater than 0');
expect(() => createRateLimiter(counters, { limit: 0, windowMs: 1000 })).toThrow('limit must be a finite number greater than 0');
expect(() => createRateLimiter(counters, { limit: -1, windowMs: 1000 })).toThrow('limit must be a finite number greater than 0');
expect(() => createRateLimiter(counters, { limit: Number.NaN, windowMs: 1000 })).toThrow('limit must be a finite number greater than 0');
expect(() => createRateLimiter(counters, { limit: Number.POSITIVE_INFINITY, windowMs: 1000 })).toThrow('limit must be a finite number greater than 0');
expect(() => createRateLimiter(counters, { limit: 5, windowMs: 0 })).toThrow('windowMs must be a finite number greater than 0');
expect(() => createRateLimiter(counters, { limit: 5, windowMs: -1 })).toThrow('windowMs must be a finite number greater than 0');
expect(() => createRateLimiter(counters, { limit: 5, windowMs: Number.NaN })).toThrow('windowMs must be a finite number greater than 0');
expect(() => createRateLimiter(counters, { limit: 5, windowMs: Number.POSITIVE_INFINITY })).toThrow('windowMs must be a finite number greater than 0');
});

it('allows exactly limit requests and blocks the next one', async () => {
Expand Down