Repository navigation
Logo list size and speed - #2514
Merged
Merged
Conversation
Editors can choose logo height and scroll speed of logo lists via sliders. Steps are defined as theme scales with defaults whose middle step matches the previous fixed values, so existing logo lists keep their appearance. Themes can override the scales to offer different steps. getScale accepts a default value property name to let content elements determine slider defaults without registering their scales centrally.
Selected logo lists render as a static list to allow editing items. This made it impossible to see the effect of the speed slider. The marquee now plays while the slider handle is dragged. Slider inputs accept a callback for the end of an interaction, and a slider input domino lets specs simulate sliding.
Verbal speed labels were too long to render next to the slider. Multipliers derived from the theme values stay short and label custom theme scales without additional translations. Themes can still provide translated labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.