Repository navigation
Phone app: keep screens clear of the iPhone Duo cover screen rail - #267
Merged
Merged
Conversation
The cover screen puts the status bar, tab bar and header buttons in a column on the right (84 pt safe-area inset). Screens ignored side insets, so cards and the composer ran under the rail. Stack screens now pad by the left/right safe-area insets; (tabs) and the settings modal skip it because their nested stacks already pad.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the iPhone Duo cover screen, iOS puts the status bar, the tab bar and the header buttons in a column on the right (84 pt right safe-area inset). Our screens ignored side insets, so the composer, cards and list rows ran under the rail.
usePageStyle()inlib/theme.ts: background plus left/right safe-area paddingcontentStylein the root stack and inTabStack;(tabs)and the settings modal keep a plain background because their nested stacks already pad (no double inset)Tested on the iPhone Duo simulator (iOS 27.1, cover display) against a sandbox core: Home, Chats, chat, New chat sheet, Settings, light and dark. JS only.