Skip to content

Commit c8a7eb5

Browse files
author
Oussama
committed
fix: compact globe country card
1 parent 7f8212d commit c8a7eb5

2 files changed

Lines changed: 47 additions & 23 deletions

File tree

website/src/lib/scenes/Scene2Globe.svelte

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@
147147
<div>
148148
<dt>Breadth</dt>
149149
<dd>
150-
{selectedSummary.featured_artist_n_departments} departments · {selectedSummary.featured_artist_n_mediums}
150+
{selectedSummary.featured_artist_n_departments} departments / {selectedSummary.featured_artist_n_mediums}
151151
media
152152
</dd>
153153
</div>
@@ -160,12 +160,13 @@
160160
<span>{selectedWorkYear}</span>
161161
{/if}
162162
</p>
163-
<p class="caveat">
164-
This is a transparent collection-based proxy, not a true fame ranking.
165-
{#if selectedSummary.featured_artist_score_method}
166-
{selectedSummary.featured_artist_score_method}
167-
{/if}
168-
</p>
163+
<p class="caveat">Collection-based proxy, not a true fame ranking.</p>
164+
{#if selectedSummary.featured_artist_score_method}
165+
<details class="score-method">
166+
<summary>How score is computed</summary>
167+
<p>{selectedSummary.featured_artist_score_method}</p>
168+
</details>
169+
{/if}
169170
{#if selectedArtistUrl}
170171
<a class="moma-link" href={selectedArtistUrl} target="_blank" rel="noopener">Open artist on MoMA</a>
171172
{/if}

website/src/lib/scenes/scene2Globe.css

Lines changed: 39 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,10 @@
7575
right: var(--space-4);
7676
top: var(--space-4);
7777
z-index: 3;
78-
width: min(28rem, calc(100vw - var(--space-4)));
79-
padding: var(--space-3);
78+
width: min(23rem, calc(100vw - var(--space-4)));
79+
max-height: calc(100vh - var(--space-4));
80+
overflow: auto;
81+
padding: var(--space-2);
8082
color: var(--fg-on-dark-strong);
8183
background: color-mix(in srgb, var(--bg-dark) 88%, transparent);
8284
border: 1px solid var(--fg-on-dark-mute);
@@ -102,17 +104,17 @@
102104
}
103105

104106
.scene-globe h3 {
105-
margin: var(--space-3) 0 var(--space-2);
107+
margin: var(--space-2) 0 var(--space-1);
106108
color: var(--fg-on-dark-strong);
107109
font-family: var(--font-display);
108-
font-size: var(--type-h2-size);
110+
font-size: clamp(1.5rem, 3vw, 2rem);
109111
}
110112

111113
.scene-globe dl {
112114
display: grid;
113-
gap: var(--space-1);
115+
gap: 0.375rem;
114116
margin: 0;
115-
padding: var(--space-2) 0;
117+
padding: var(--space-1) 0;
116118
border-top: 1px solid color-mix(in srgb, var(--fg-on-dark-mute) 34%, transparent);
117119
border-bottom: 1px solid color-mix(in srgb, var(--fg-on-dark-mute) 34%, transparent);
118120
}
@@ -136,7 +138,7 @@
136138

137139
.artist-label {
138140
position: relative;
139-
margin: var(--space-3) 0 0;
141+
margin: var(--space-2) 0 0;
140142
padding: var(--space-2);
141143
background: color-mix(in srgb, var(--fg-on-dark-strong) 6%, transparent);
142144
border: 1px solid color-mix(in srgb, var(--fg-on-dark-mute) 42%, transparent);
@@ -169,8 +171,8 @@
169171

170172
.artist-heading {
171173
display: grid;
172-
grid-template-columns: 4rem 1fr;
173-
gap: var(--space-2);
174+
grid-template-columns: 3.25rem 1fr;
175+
gap: var(--space-1);
174176
align-items: center;
175177
margin: var(--space-1) 0 var(--space-2);
176178
}
@@ -183,14 +185,14 @@
183185
border-radius: 50%;
184186
color: var(--accent-primary);
185187
font-family: var(--font-display);
186-
font-size: var(--type-h2-size);
188+
font-size: 1.35rem;
187189
}
188190

189191
.artist-heading h4 {
190192
margin: 0;
191193
color: var(--fg-on-dark-strong);
192194
font-family: var(--font-display);
193-
font-size: clamp(var(--type-h2-size), 4vw, var(--type-h1-size));
195+
font-size: clamp(1.5rem, 3vw, 2rem);
194196
line-height: var(--type-h1-line);
195197
}
196198

@@ -203,15 +205,15 @@
203205

204206
.artist-label .story {
205207
margin: 0;
206-
font-size: var(--type-body-size);
207-
line-height: var(--type-body-line);
208+
font-size: 0.9375rem;
209+
line-height: 1.45;
208210
}
209211

210212
.artist-label .score-card {
211213
display: grid;
212214
grid-template-columns: repeat(3, minmax(0, 1fr));
213215
gap: var(--space-1);
214-
margin: var(--space-2) 0 0;
216+
margin: var(--space-1) 0 0;
215217
padding: var(--space-1) 0 0;
216218
border-top: 1px solid color-mix(in srgb, var(--fg-on-dark-mute) 28%, transparent);
217219
}
@@ -238,8 +240,8 @@
238240
.artist-label .representative {
239241
display: grid;
240242
gap: 0.125rem;
241-
margin: var(--space-2) 0 0;
242-
padding-top: var(--space-2);
243+
margin: var(--space-1) 0 0;
244+
padding-top: var(--space-1);
243245
border-top: 1px solid color-mix(in srgb, var(--fg-on-dark-mute) 28%, transparent);
244246
font-size: var(--type-small-size);
245247
}
@@ -259,6 +261,27 @@
259261
color: color-mix(in srgb, var(--fg-on-dark-mute) 76%, transparent);
260262
}
261263

264+
.score-method {
265+
margin-top: var(--space-1);
266+
color: var(--fg-on-dark-mute);
267+
font-family: var(--font-ui);
268+
font-size: var(--type-small-size);
269+
}
270+
271+
.score-method summary {
272+
cursor: pointer;
273+
}
274+
275+
.score-method summary:hover,
276+
.score-method summary:focus-visible {
277+
color: var(--accent-primary);
278+
}
279+
280+
.score-method p {
281+
margin: var(--space-1) 0 0;
282+
line-height: var(--type-small-line);
283+
}
284+
262285
.moma-link {
263286
display: inline-flex;
264287
margin-top: var(--space-2);

0 commit comments

Comments
 (0)