Commit 8a4a8ec
docs: correct the OOM-arm discharge in RedisStreamCodec — no publish-time guard ships
Folded in from #8145 (closed in favour of carrying it here), addressing review
feedback on #8089 that landed after that PR merged.
The javadoc justified absorbing an OutOfMemoryError by pointing at a
publish-time size guard as the control covering the residual risk, naming
onlineScoring.dropOversizedPayloads. That key does not exist: a repo-wide grep
returns exactly one hit, the sentence itself.
It never shipped. #8060 was merged as the Guice/Dropwizard ordering fix that
made the codec actually receive maxStringLength; the publisher-side drop guard
it originally carried was cut from that PR before merge, under this or any
other name.
That matters more than a stale reference normally would, because of the job
the sentence was doing. The paragraph above it makes the most serious
admission in the design -- under real heap pressure this arm absorbs an OOM
that was a symptom rather than a cause and keeps consuming, masking it -- and
this sentence was its discharge. With no such guard the risk is open, not
delegated, and someone auditing the decision later would go looking for a
control that was never built.
Wording as suggested in review. Comment-only: the OOM-absorbing call itself is
unchanged and not in question.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 2b96045 commit 8a4a8ec
1 file changed
Lines changed: 3 additions & 2 deletions
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
164 | 164 | | |
165 | 165 | | |
166 | 166 | | |
167 | | - | |
168 | | - | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
169 | 170 | | |
170 | 171 | | |
171 | 172 | | |
| |||
0 commit comments