Commit cc90574
[OPIK-7773] [BE] fix: correct the runbook's restart attribution and the readiness DTO builder
Two more review findings, both in scope.
The runbook's self-clearing note had the restart on the wrong path: it read "no extra restart
needed on the wrap-first path, and only the already-planned restart on the toggle-first path",
which is backwards. Both orderings spend exactly the one planned rolling restart the toggle
already requires, and neither needs another; what differs is its position, and with it what
closes the mismatch window — the wrap DDL on the toggle-first path (the restart is already
done by then), the restart completing on the wrap-first path. Reworded to say that.
HealthCheckResponse used a plain @builder, copied from the same record in
HealthCheckIntegrationTest, where the convention predates the rule. Records and DTOs take
@builder(toBuilder = true) (.agents/skills/opik-backend/SKILL.md:52, which lists bare @builder
as the anti-pattern), so the new copy uses it; the older one is left alone as unrelated to
this ticket.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent a810a6b commit cc90574
2 files changed
Lines changed: 5 additions & 3 deletions
File tree
- apps/opik-backend
- data-migrations/traces-local-v2-cutover
- src/test/java/com/comet/opik/infrastructure/db/healthchecks
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
237 | 237 | | |
238 | 238 | | |
239 | 239 | | |
240 | | - | |
241 | | - | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
242 | 244 | | |
243 | 245 | | |
244 | 246 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
272 | 272 | | |
273 | 273 | | |
274 | 274 | | |
275 | | - | |
| 275 | + | |
276 | 276 | | |
277 | 277 | | |
278 | 278 | | |
0 commit comments