[NA] fix(dev-runner): use -DskipTests for EM backend build so comet-mpm-service's test-jar is produced - #7563
Merged
Conversation
…backend build comet-ml-mpm-webapp depends on comet-mpm-service's test-jar as a reactor dependency. -Dmaven.test.skip=true skips test compilation entirely, so the test-jar never gets produced and the reactor build fails with: Could not find artifact com.comet:comet-mpm-service:jar:tests:1.0-SNAPSHOT -DskipTests still compiles test sources (producing the test-jar) but skips running the tests, so the reactor resolves cleanly.
Contributor
⏱️ pre-commit per-hook timingNo linted files changed — nothing to run. ⏭️ 41 skipped (no matching files changed)
|
petrotiurin
changed the title
![baz-reviewer[bot]](https://avatars.githubusercontent.com/in/933528?s=60&v=4){kind=small}
petrotiurin
marked this pull request as ready for review
July 22, 2026 10:16
Contributor
|
👋 Review summary What looks good
Overall Inline comments: None — looks clean! 🤖 Review posted via /review-github-pr |
JetoPistola
approved these changes
Jul 22, 2026
JetoPistola
left a comment
JetoPistola
left a comment
Contributor
There was a problem hiding this comment.
Approving — clean, correctly-diagnosed dev-tooling fix. -DskipTests compiles comet-mpm-service's test sources (producing the test-jar comet-ml-mpm-webapp needs) while still skipping test execution, so the EM reactor resolves. Minimal, well-scoped, and verified end-to-end by the author.
🤖 Review posted via /review-github-pr
andrescrz
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
platform_restart_build()builds the EM backend reactor (comet-ml-react-webapp -am) with-Dmaven.test.skip=true, which skips test compilation as well as execution.comet-ml-mpm-webapp(a reactor dependency ofcomet-ml-react-webapp) needscomet-mpm-service's test-jar as a test-scoped dependency, so skipping test compilation means that jar never gets produced/attached and the reactor fails to resolve it — leaving the EM backend permanentlySTOPPEDon any freshcomet-backendcheckout. Swapping to-DskipTestsstill skips running the tests (same speed benefit) but compiles them, so the test-jar goal has classes to package.mvn -pl comet-ml-react-webapp -am clean install -Dmaven.test.skip=true ...→BUILD FAILURE:Could not find artifact com.comet:comet-mpm-service:jar:tests:1.0-SNAPSHOTChange checklist
Issues
AI-WATERMARK
AI-WATERMARK: yes
comet-mpm-serviceandcomet-ml-react-webapplocally and running./scripts/dev-runner.sh --restart --platform-enabledend-to-end (EM backend reachedRUNNING/ready), reviewing before mergeTesting
Commands run (in
comet-backend, JDK 17 via/usr/libexec/java_home -v 17):mvn -pl comet-mpm-service -am install -T 1C -DskipTests -Dspotless.skip=true -Dmaven.javadoc.skip=true -Dmaven.source.skip=true→BUILD SUCCESS, produced and installedcomet-mpm-service-1.0-SNAPSHOT-tests.jarmvn -pl comet-ml-react-webapp -am install -T 1C -DskipTests -Dspotless.skip=true -Dmaven.javadoc.skip=true -Dmaven.source.skip=true→BUILD SUCCESS./scripts/dev-runner.sh --restart --platform-enabled(fromopik/) → EM backend built, started, and reportedRUNNING (PID ...)/ "EM backend is ready and accepting connections"Scenarios validated:
comet-backendcheckout with no priortarget/build (the original failing case) — confirmed the exactBUILD FAILUREbefore the fix.--restart --platform-enabledflow after the fix, local process mode (not Docker) on macOS.Not run: comet-backend's own test suite (intentionally skipped by design — this is a local dev-tooling build, not a CI path).
Documentation
None needed — internal dev script only.