-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[OPIK-8183] [BE] feat: accept CIPX device tokens and record device_id on cipx identities #8094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
LifeXplorer
merged 24 commits into
main
from
avinahradau/OPIK-8183-cipx-device-token-auth
Sep 3, 2026
+883
−31
Merged
Changes from 12 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
0b1f43d
[OPIK-8183] [BE] feat: accept CIPX device tokens and record device_id…
LifeXplorer 82b15b1
[OPIK-8183] [BE] perf: cache the resolved credential on the CIPX toke…
LifeXplorer c3bed02
[OPIK-8183] [BE] feat: authenticate the CIPX validate call with a ser…
LifeXplorer c7813de
[OPIK-8183] [BE] refactor: drop device_id from SpansCreated
LifeXplorer 028c467
[OPIK-8183] [BE] fix: resolve the CIPX caller from the validate respo…
LifeXplorer 41af213
[OPIK-8183] [BE] test: cover the CIPX ingest-only allowlist
LifeXplorer c566039
OPIK-8183 refactor comments
LifeXplorer 403f094
[OPIK-8183] [BE] fix: move the CIPX validator off the publicly routed…
LifeXplorer 460b995
[OPIK-8183] [BE] refactor: drop the CIPX validator service credential
LifeXplorer 3c58630
OPIK-8183 refactor comments
LifeXplorer a6794a0
[OPIK-8183] [BE] refactor: validate CIPX device tokens by token alone
LifeXplorer 08a6410
[OPIK-8183] [BE] docs: say that a device token's user name is an email
LifeXplorer 0fef387
OPIK-8183 refactor
LifeXplorer 6c05e84
[OPIK-8183] [BE] test: generate the opaque ids in the CIPX tests
LifeXplorer 7d79b86
[OPIK-8183] [BE] test: give the CIPX fixtures the user name a validat…
LifeXplorer dcc66e3
Merge branch 'main' into avinahradau/OPIK-8183-cipx-device-token-auth
LifeXplorer 6c77ef1
OPIK-8183 update generate rate limit principal
LifeXplorer 2cb3edb
OPIK-8183 update validation
LifeXplorer 60b0143
OPIK-8183 cache by token sha, not raw value
LifeXplorer 5b11640
OPIK-8183 resolve review items
LifeXplorer a8016c8
OPIK-8183 reduce validation t/o
LifeXplorer 7c070a3
Merge branch 'main' into avinahradau/OPIK-8183-cipx-device-token-auth
LifeXplorer c83c05f
Merge branch 'main' into avinahradau/OPIK-8183-cipx-device-token-auth
LifeXplorer 240a215
Merge branch 'main' into avinahradau/OPIK-8183-cipx-device-token-auth
LifeXplorer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
apps/opik-backend/src/main/java/com/comet/opik/infrastructure/CipxTokenValidationConfig.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| package com.comet.opik.infrastructure; | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
| import jakarta.validation.Valid; | ||
| import lombok.AllArgsConstructor; | ||
| import lombok.Builder; | ||
| import lombok.Data; | ||
| import lombok.NoArgsConstructor; | ||
|
|
||
| /** | ||
| * Delegated validation of CIPX device tokens. Disabled by default: with {@code enabled=false} the | ||
| * authentication filter never looks at the CIPX token prefix, so self-hosted and local deployments | ||
| * behave exactly as before. | ||
| */ | ||
| @Data | ||
| @Builder(toBuilder = true) | ||
| @NoArgsConstructor | ||
| @AllArgsConstructor | ||
| public class CipxTokenValidationConfig { | ||
|
|
||
| @Valid @JsonProperty | ||
| private boolean enabled; | ||
|
|
||
| @Valid @JsonProperty | ||
| private String url; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.