Skip to content

docs: correct the OOM-arm discharge in RedisStreamCodec — no publish-time guard ships #8145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thiagohora wants to merge 1 commit into from
+3 −2
Closed

docs: correct the OOM-arm discharge in RedisStreamCodec — no publish-time guard ships #8145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apps/opik-backend/src/main/java/com/comet/opik/infrastructure/redis/RedisStreamCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,9 @@ public static Codec faultTolerant(Codec delegate) {
* a cause, and keep consuming — masking it. The recovery measured above is single-threaded and
* proves the decode path, not a loaded service; an allocation large enough to fail can still starve
* a different thread, which throws where nothing catches it. The counter to that is a size guard at
* publish time, which is what {@code onlineScoring.dropOversizedPayloads} does, not anything this
* codec can do on read.
* publish time. No such guard ships today -- #8060 applied the codec's stream-read limits but added
* no publisher-side size check -- so this residual risk is open rather than delegated. It is not
* something this codec can address on read.
* <p>
* No other {@link Error} is absorbed — a {@link StackOverflowError} still propagates.
*/
Expand Down
Loading